From: channing <chao.bi@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
grant.likely@secretlab.ca, linux-kernel@vger.kernel.org,
sylvain.centelles@intel.com, ken.k.mills@intel.com,
jun.d.chen@intel.com, alan@linux.intel.com
Subject: Re: [PATCH] SPI: SSP SPI Controller driver v3
Date: Mon, 07 Jan 2013 16:05:43 +0800 [thread overview]
Message-ID: <1357545943.28451.9.camel@bichao> (raw)
In-Reply-To: <CACRpkdaw7Yc0OetPWK7Cv=JsVPOs6b1Tr-=4jE5Vz4oTD6f07Q@mail.gmail.com>
On Mon, 2013-01-07 at 00:36 +0100, Linus Walleij wrote:
> On Wed, Dec 19, 2012 at 10:56 AM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Tue, Dec 18, 2012 at 04:11:36PM +0800, chao bi wrote:
> >>
> >> This patch is to implement SSP SPI controller driver, which has been applied and
> >> validated on intel Moorestown & Medfield platform. The patch are originated by
> >> Ken Mills <ken.k.mills@intel.com> and Sylvain Centelles <sylvain.centelles@intel.com>,
> >> migrating to lateset Linux mainline SPI framework by Channing <chao.bi@intel.com>
> >> and Chen Jun <jun.d.chen@intel.com> according to their integration & validation
> >> on Medfield platform.
> >
> > This is the same IP block as used in PXA, right? With few modifications
> > here and there. Is there a reason not to use spi-pxa2xx.c?
>
> This needs to be investigated. Two drivers for the same or closely related
> hardware block is never a good sign...
>
> Yours,
> Linus Walleij
Dear Linus ,Mika and Grant,
Thanks for your remind.
Frankly I'm currently not sure whether they share same IP.. per your reminds, I tried to find but get
limited info about PXA SSP's IP, from the code, looks like they have part of registers the same.
As far as I know, spi-pxa2xx.c is specific for SSP controller of PXA2XX/PXA3XX core, right? While Medfield
platform is embedded with ATOM core, the SSP driver we upload is validated on SSP controller of ATOM. In my
view, they're specific for different AP & Platforms, if compare the 2 files, there are still many difference
in how they works, if to choose a driver for Intel Medfild/Moorestown platform, I believe spi-intel-mid-ssp.c
driver could be a more mature solution.
What do you think? please correct me if I'm mistaken.
-chao
next prev parent reply other threads:[~2013-01-07 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 8:11 [PATCH] SPI: SSP SPI Controller driver v3 chao bi
2012-12-19 9:56 ` Mika Westerberg
2013-01-06 23:36 ` Linus Walleij
2013-01-07 8:05 ` channing [this message]
2013-01-07 10:21 ` Linus Walleij
2013-01-07 10:36 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357545943.28451.9.camel@bichao \
--to=chao.bi@intel.com \
--cc=alan@linux.intel.com \
--cc=grant.likely@secretlab.ca \
--cc=jun.d.chen@intel.com \
--cc=ken.k.mills@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sylvain.centelles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox