* [PATCH 1/3] Staging: speakup: buffers.c: checkpatch.pl fixes
@ 2013-01-08 18:39 Lijo Antony
2013-01-08 18:39 ` [PATCH 2/3] Staging: speakup: keyhelp.c: " Lijo Antony
2013-01-08 18:39 ` [PATCH 3/3] Staging: speakup: kobjects.c: " Lijo Antony
0 siblings, 2 replies; 3+ messages in thread
From: Lijo Antony @ 2013-01-08 18:39 UTC (permalink / raw)
To: gregkh; +Cc: w.d.hubbs, chris, kirk, samuel.thibault, linux-kernel,
Lijo Antony
Fixed two camel case issues.
Signed-off-by: Lijo Antony <lijo.kernel@gmail.com>
---
drivers/staging/speakup/buffers.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/speakup/buffers.c b/drivers/staging/speakup/buffers.c
index a2db956..382973e 100644
--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -5,12 +5,12 @@
#include "speakup.h"
#include "spk_priv.h"
-#define synthBufferSize 8192 /* currently 8K bytes */
+#define SYNTH_BUF_SIZE 8192 /* currently 8K bytes */
-static u_char synth_buffer[synthBufferSize]; /* guess what this is for! */
+static u_char synth_buffer[SYNTH_BUF_SIZE]; /* guess what this is for! */
static u_char *buff_in = synth_buffer;
static u_char *buff_out = synth_buffer;
-static u_char *buffer_end = synth_buffer+synthBufferSize-1;
+static u_char *buffer_end = synth_buffer + SYNTH_BUF_SIZE - 1;
/* These try to throttle applications by stopping the TTYs
* Note: we need to make sure that we will restart them eventually, which is
@@ -44,13 +44,13 @@ static void speakup_stop_ttys(void)
static int synth_buffer_free(void)
{
- int bytesFree;
+ int bytes_free;
if (buff_in >= buff_out)
- bytesFree = synthBufferSize - (buff_in - buff_out);
+ bytes_free = SYNTH_BUF_SIZE - (buff_in - buff_out);
else
- bytesFree = buff_out - buff_in;
- return bytesFree;
+ bytes_free = buff_out - buff_in;
+ return bytes_free;
}
int synth_buffer_empty(void)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] Staging: speakup: keyhelp.c: checkpatch.pl fixes
2013-01-08 18:39 [PATCH 1/3] Staging: speakup: buffers.c: checkpatch.pl fixes Lijo Antony
@ 2013-01-08 18:39 ` Lijo Antony
2013-01-08 18:39 ` [PATCH 3/3] Staging: speakup: kobjects.c: " Lijo Antony
1 sibling, 0 replies; 3+ messages in thread
From: Lijo Antony @ 2013-01-08 18:39 UTC (permalink / raw)
To: gregkh; +Cc: w.d.hubbs, chris, kirk, samuel.thibault, linux-kernel,
Lijo Antony
Breaking 2 lines to fit 80 char limit
Signed-off-by: Lijo Antony <lijo.kernel@gmail.com>
---
drivers/staging/speakup/keyhelp.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/keyhelp.c b/drivers/staging/speakup/keyhelp.c
index 4c584ec..5091625 100644
--- a/drivers/staging/speakup/keyhelp.c
+++ b/drivers/staging/speakup/keyhelp.c
@@ -118,7 +118,8 @@ static void say_key(int key)
synth_printf(" %s", spk_msg_get(MSG_STATES_START + i));
}
if ((key > 0) && (key <= num_key_names))
- synth_printf(" %s\n", spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
+ synth_printf(" %s\n",
+ spk_msg_get(MSG_KEYNAMES_START + (key - 1)));
}
static int help_init(void)
@@ -169,7 +170,9 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key)
cur_item--;
else
return -1;
- } else if (type == KT_SPKUP && ch == SPEAKUP_HELP && !spk_special_handler) {
+ } else if (type == KT_SPKUP
+ && ch == SPEAKUP_HELP
+ && !spk_special_handler) {
spk_special_handler = spk_handle_help;
synth_printf("%s\n", spk_msg_get(MSG_HELP_INFO));
build_key_data(); /* rebuild each time in case new mapping */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] Staging: speakup: kobjects.c: checkpatch.pl fixes
2013-01-08 18:39 [PATCH 1/3] Staging: speakup: buffers.c: checkpatch.pl fixes Lijo Antony
2013-01-08 18:39 ` [PATCH 2/3] Staging: speakup: keyhelp.c: " Lijo Antony
@ 2013-01-08 18:39 ` Lijo Antony
1 sibling, 0 replies; 3+ messages in thread
From: Lijo Antony @ 2013-01-08 18:39 UTC (permalink / raw)
To: gregkh; +Cc: w.d.hubbs, chris, kirk, samuel.thibault, linux-kernel,
Lijo Antony
Fixed two "line over 80 characters" warnings reported by checkpatch.pl
Signed-off-by: Lijo Antony <lijo.kernel@gmail.com>
---
drivers/staging/speakup/kobjects.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index 86387f4..35f647c 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -654,16 +654,16 @@ ssize_t spk_var_store(struct kobject *kobj, struct kobj_attribute *attr,
if (synth && synth->default_pitch) {
param = spk_var_header_by_name("pitch");
if (param) {
- spk_set_num_var(synth->default_pitch[value], param,
- E_NEW_DEFAULT);
+ spk_set_num_var(synth->default_pitch[value],
+ param, E_NEW_DEFAULT);
spk_set_num_var(0, param, E_DEFAULT);
}
}
if (synth && synth->default_vol) {
param = spk_var_header_by_name("vol");
if (param) {
- spk_set_num_var(synth->default_vol[value], param,
- E_NEW_DEFAULT);
+ spk_set_num_var(synth->default_vol[value],
+ param, E_NEW_DEFAULT);
spk_set_num_var(0, param, E_DEFAULT);
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-08 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 18:39 [PATCH 1/3] Staging: speakup: buffers.c: checkpatch.pl fixes Lijo Antony
2013-01-08 18:39 ` [PATCH 2/3] Staging: speakup: keyhelp.c: " Lijo Antony
2013-01-08 18:39 ` [PATCH 3/3] Staging: speakup: kobjects.c: " Lijo Antony
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox