public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>,
	linux-kernel@vger.kernel.org,
	Viresh Kumar <viresh.kumar@linaro.org>,
	spear-devel <spear-devel@list.st.com>
Subject: [resend][PATCH 12/16] dw_dmac: check for mapping errors
Date: Wed,  9 Jan 2013 10:17:11 +0200	[thread overview]
Message-ID: <1357719435-29955-13-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1357719435-29955-1-git-send-email-andriy.shevchenko@linux.intel.com>

Otherwise we get a warning in case of CONFIG_DMA_API_DEBUG=y

[   45.775943] WARNING: at lib/dma-debug.c:933 check_unmap+0x5d6/0x6ac()
[   45.782369] dw_dmac dw_dmac.0: DMA-API: device driver failed to check map error[device address=0x00000000356efcc0] [size=28 bytes] [mapped as single]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/dma/dw_dmac.c |   20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 39a6506..83e0f9e 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1107,6 +1107,7 @@ static int dwc_alloc_chan_resources(struct dma_chan *chan)
 	struct dw_desc		*desc;
 	int			i;
 	unsigned long		flags;
+	int			ret;
 
 	dev_vdbg(chan2dev(chan), "%s\n", __func__);
 
@@ -1130,12 +1131,8 @@ static int dwc_alloc_chan_resources(struct dma_chan *chan)
 		spin_unlock_irqrestore(&dwc->lock, flags);
 
 		desc = kzalloc(sizeof(struct dw_desc), GFP_KERNEL);
-		if (!desc) {
-			dev_info(chan2dev(chan),
-				"only allocated %d descriptors\n", i);
-			spin_lock_irqsave(&dwc->lock, flags);
-			break;
-		}
+		if (!desc)
+			goto err_desc_alloc;
 
 		INIT_LIST_HEAD(&desc->tx_list);
 		dma_async_tx_descriptor_init(&desc->txd, chan);
@@ -1143,6 +1140,10 @@ static int dwc_alloc_chan_resources(struct dma_chan *chan)
 		desc->txd.flags = DMA_CTRL_ACK;
 		desc->txd.phys = dma_map_single(chan2parent(chan), &desc->lli,
 				sizeof(desc->lli), DMA_TO_DEVICE);
+		ret = dma_mapping_error(chan2parent(chan), desc->txd.phys);
+		if (ret)
+			goto err_desc_alloc;
+
 		dwc_desc_put(dwc, desc);
 
 		spin_lock_irqsave(&dwc->lock, flags);
@@ -1154,6 +1155,13 @@ static int dwc_alloc_chan_resources(struct dma_chan *chan)
 	dev_dbg(chan2dev(chan), "%s: allocated %d descriptors\n", __func__, i);
 
 	return i;
+
+err_desc_alloc:
+	kfree(desc);
+
+	dev_info(chan2dev(chan), "only allocated %d descriptors\n", i);
+
+	return i;
 }
 
 static void dwc_free_chan_resources(struct dma_chan *chan)
-- 
1.7.10.4


  parent reply	other threads:[~2013-01-09  8:17 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 12:54 dw_dmac patches Andy Shevchenko
2013-01-08 15:54 ` Vinod Koul
2013-01-09  8:16   ` [resend][PATCH 00/16] dw_dmac related patchset Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 01/16] dw_dmac: call .probe after we have a device in place Andy Shevchenko
2013-01-09 13:47       ` Vinod Koul
2013-01-09 14:56         ` Andy Shevchenko
2013-01-09 15:38           ` Vinod Koul
2013-01-09 18:04             ` Mika Westerberg
2013-01-12 12:28               ` Vinod Koul
2013-01-10  8:34             ` Viresh Kumar
2013-01-12 12:30               ` Vinod Koul
2013-01-09  8:17     ` [resend][PATCH 02/16] dw_dmac: absence of pdata isn't critical when autocfg is set Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function Andy Shevchenko
2013-01-09 13:50       ` Vinod Koul
2013-01-09 14:19         ` Viresh Kumar
2013-01-09 14:58           ` Andy Shevchenko
2013-01-09 15:10             ` Vinod Koul
2013-01-09 15:51               ` Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 04/16] dma: at_hdmac: check direction properly for cyclic transfers Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 05/16] dma: dw_dmac: check direction properly in dw_dma_cyclic_prep Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 06/16] dma: ep93xx_dma: reuse is_slave_xfer helper Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 07/16] dma: ipu_idmac: " Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 08/16] dma: ste_dma40: " Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 09/16] dw_dmac: store direction in the custom channel structure Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 10/16] dw_dmac: make usage of dw_dma_slave optional Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 11/16] dw_dmac: backlink to dw_dma in dw_dma_chan is superfluous Andy Shevchenko
2013-01-09 14:24       ` Vinod Koul
2013-01-09 15:02         ` Andy Shevchenko
2013-01-09 15:11           ` Vinod Koul
2013-01-09  8:17     ` Andy Shevchenko [this message]
2013-01-09  8:17     ` [resend][PATCH 13/16] dw_dmac: remove redundant check Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 14/16] dw_dmac: update tx_node_active in dwc_do_single_block Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 15/16] dma: dw_dmac: add dwc_chan_pause and dwc_chan_resume Andy Shevchenko
2013-01-09  8:17     ` [resend][PATCH 16/16] dma: dw_dmac: clear suspend bit during termination Andy Shevchenko
2013-01-09 14:18       ` Vinod Koul
2013-01-09 15:07         ` Andy Shevchenko
2013-01-09 15:44     ` [resend][PATCH 00/16] dw_dmac related patchset Vinod Koul
2013-01-10  8:28       ` Andy Shevchenko
2013-01-09 11:26   ` dw_dmac patches Andy Shevchenko
2013-01-11 12:01   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357719435-29955-13-git-send-email-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spear-devel@list.st.com \
    --cc=vinod.koul@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox