linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, chavey@google.com, fengguang.wu@intel.com
Subject: [PATCHSET] block: improve tracepoints, take#2
Date: Fri, 11 Jan 2013 13:06:32 -0800	[thread overview]
Message-ID: <1357938397-5413-1-git-send-email-tj@kernel.org> (raw)

Hello, Jens.

This is the second take.  Changes from the first take[L] are

* writeback_dirty_buffer TP was botched.  It made build fail when
  CONFIG_BLOCK is not set (reported by Fengguang) and I somehow lost
  its actual triggering in mark_buffer_dirty() while splitting
  patches.  Made it a block TP instead so that it can share TP
  definition with block_touch_buffer and restored the triggering from
  mark_buffer_dirty().

This patchset fixes/improves bio_complete TP so that block layer
proper triggers for all completing bios instead of stackign drivers
triggering them manually and adds more buffer / block / writeback TPs.
These improve visibility in general and are already in use in google.

This patchset contains the following five patches.

0001-block-add-missing-block_bio_complete-tracepoint.patch
0002-block-add-req-to-bio_-front-back-_merge-tracepoints.patch
0003-buffer-make-touch_buffer-an-exported-function.patch
0004-block-add-block_-touch-dirty-_buffer-tracepoint.patch
0005-writeback-add-more-tracepoints.patch

It's based on top of v3.8-rc2 and also available in the following git
branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-tps

diffstat follows.  Thanks.

 block/blk-core.c                 |    5 -
 drivers/md/dm.c                  |    1
 drivers/md/raid5.c               |   11 ---
 fs/bio.c                         |    2
 fs/buffer.c                      |   10 +++
 fs/fs-writeback.c                |   16 ++++-
 include/linux/blktrace_api.h     |    1
 include/linux/buffer_head.h      |    2
 include/trace/events/block.h     |  104 +++++++++++++++++++++++++++++-----
 include/trace/events/writeback.h |  116 +++++++++++++++++++++++++++++++++++++++
 kernel/trace/blktrace.c          |   28 ++++++++-
 mm/page-writeback.c              |    2
 12 files changed, 263 insertions(+), 35 deletions(-)

--
tejun

[L] http://thread.gmane.org/gmane.linux.kernel/1419141

             reply	other threads:[~2013-01-11 21:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 21:06 Tejun Heo [this message]
2013-01-11 21:06 ` [PATCH 1/5] block: add missing block_bio_complete() tracepoint Tejun Heo
2013-01-11 21:06 ` [PATCH 2/5] block: add @req to bio_{front|back}_merge tracepoints Tejun Heo
2013-01-11 21:06 ` [PATCH 3/5] buffer: make touch_buffer() an exported function Tejun Heo
2013-01-11 21:06 ` [PATCH 4/5] block: add block_{touch|dirty}_buffer tracepoint Tejun Heo
2013-01-11 21:06 ` [PATCH 5/5] writeback: add more tracepoints Tejun Heo
2013-01-12  3:17   ` Fengguang Wu
2013-01-14 13:57     ` Jan Kara
2013-01-14 14:02 ` [PATCHSET] block: improve tracepoints, take#2 Jens Axboe
2013-01-14 17:43   ` Tejun Heo
2013-01-14 18:22     ` [PATCH] writeback: mark sysctl vm.block_dump for removal Tejun Heo
2013-01-14 19:00       ` Jan Kara
2013-01-15 16:28       ` [PATCH v2] " Tejun Heo
2013-01-16  2:07         ` Jan Kara
2013-01-16  2:53           ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357938397-5413-1-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=chavey@google.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).