public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: "John Stultz" <john.stultz@linaro.org>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Serban Constantinescu" <serban.constantinescu@arm.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Android Kernel Team" <kernel-team@android.com>
Subject: [RFC][PATCH 0/2] staging: alarm-dev: compat_ioctl support
Date: Fri, 11 Jan 2013 13:48:36 -0800	[thread overview]
Message-ID: <1357940918-14941-1-git-send-email-john.stultz@linaro.org> (raw)

This is a first-pass at implementing compat_ioctl support for
Android's alarm-dev driver in staging.

The first patch is some refactoring to cleanup and separate the
copying of user data from the logic, and the second patch adds
the compat_ioctl support.

As noted in the patch, the only really squirly bit is the handling
of ANDROID_ALARM_SET_OLD and ANDROID_ALARM_SET_AND_WAIT_OLD. These
are present to support existing older Android applications.
Unfortunately these cause ioctl number aliasing issues with
the compat ioctls, so on 64bit they are only supported in the
compat patch (since any existing android app old enough to use
them are likely 32bit).

I'd appreciate feedback from the Android devs on if this is
an ok assumption and if it might be reasonable to establish
some sort of a phase-out timeline for the _OLD ioctl support.

Any other feedback or thoughts would be welcome!

thanks
-john

Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Serban Constantinescu <serban.constantinescu@arm.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Android Kernel Team <kernel-team@android.com>

John Stultz (2):
  staging: alarm-dev: Refactor alarm-dev ioctl code in prep for
    compat_ioctl
  staging: alarm-dev: Implement compat_ioctl support

 drivers/staging/android/alarm-dev.c     |  290 +++++++++++++++++++++----------
 drivers/staging/android/android_alarm.h |   19 ++
 2 files changed, 213 insertions(+), 96 deletions(-)

-- 
1.7.10.4


             reply	other threads:[~2013-01-11 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 21:48 John Stultz [this message]
2013-01-11 21:48 ` [RFC][PATCH 1/2] staging: alarm-dev: Refactor alarm-dev ioctl code in prep for compat_ioctl John Stultz
2013-01-11 21:48 ` [RFC][PATCH 2/2] staging: alarm-dev: Implement compat_ioctl support John Stultz
2013-01-11 22:03 ` [RFC][PATCH 0/2] staging: alarm-dev: " Colin Cross
2013-01-11 22:07   ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357940918-14941-1-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=arve@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serban.constantinescu@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox