From: Cruz Julian Bishop <cruzjbishop@gmail.com>
To: gregkh@linuxfoundation.org, greg@kroah.com
Cc: Cruz Julian Bishop <cruzjbishop@gmail.com>,
liodot@gmail.com, charrer@alacritech.com,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] staging: slicoss: Fix three checkpatch.pl errors in slicoss.c
Date: Mon, 14 Jan 2013 12:29:08 +1000 [thread overview]
Message-ID: <1358130549-10969-3-git-send-email-cruzjbishop@gmail.com> (raw)
In-Reply-To: <1358130549-10969-1-git-send-email-cruzjbishop@gmail.com>
The errors fixed are all instances of
"ERROR: do not use assignment in if condition"
Signed-off-by: Cruz Julian Bishop <cruzjbishop@gmail.com>
---
drivers/staging/slicoss/slicoss.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 5aa03ee..b6b99a3 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -2930,11 +2930,14 @@ static int slic_if_init(struct adapter *adapter)
}
if (!adapter->queues_initialized) {
- if ((rc = slic_rspqueue_init(adapter)))
+ rc = slic_rspqueue_init(adapter);
+ if (rc)
goto err;
- if ((rc = slic_cmdq_init(adapter)))
+ rc = slic_cmdq_init(adapter);
+ if (rc)
goto err;
- if ((rc = slic_rcvqueue_init(adapter)))
+ rc = slic_rcvqueue_init(adapter);
+ if (rc)
goto err;
adapter->queues_initialized = 1;
}
--
1.7.10.4
next prev parent reply other threads:[~2013-01-14 2:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 2:29 [PATCH 0/3] Slicoss patches Cruz Julian Bishop
2013-01-14 2:29 ` [PATCH 1/3] staging: slicoss: Stop swearing in slicoss.c Cruz Julian Bishop
2013-01-14 2:29 ` Cruz Julian Bishop [this message]
2013-01-14 2:29 ` [PATCH 3/3] staging: slicoss: Fix space-related checkpatch.pl warnings Cruz Julian Bishop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358130549-10969-3-git-send-email-cruzjbishop@gmail.com \
--to=cruzjbishop@gmail.com \
--cc=charrer@alacritech.com \
--cc=greg@kroah.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).