From: Cong Ding <dinggnu@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Matt Fleming <matt.fleming@intel.com>,
linux-kernel@vger.kernel.org
Cc: Cong Ding <dinggnu@gmail.com>
Subject: [PATCH] x86: boot/compressed/mkpiggy.c: fix resource leakage
Date: Mon, 14 Jan 2013 18:14:55 +0000 [thread overview]
Message-ID: <1358187343-15752-1-git-send-email-dinggnu@gmail.com> (raw)
the file should be closed if it goes to error.
Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
arch/x86/boot/compressed/mkpiggy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/boot/compressed/mkpiggy.c b/arch/x86/boot/compressed/mkpiggy.c
index 958a641..e29154f 100644
--- a/arch/x86/boot/compressed/mkpiggy.c
+++ b/arch/x86/boot/compressed/mkpiggy.c
@@ -58,6 +58,7 @@ int main(int argc, char *argv[])
if (fread(&olen, sizeof(olen), 1, f) != 1) {
perror(argv[1]);
+ fclose(f);
return 1;
}
--
1.7.9.5
next reply other threads:[~2013-01-14 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 18:14 Cong Ding [this message]
2013-01-15 1:18 ` [PATCH] x86: boot/compressed/mkpiggy.c: fix resource leakage David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358187343-15752-1-git-send-email-dinggnu@gmail.com \
--to=dinggnu@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox