From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371Ab3AOFUA (ORCPT ); Tue, 15 Jan 2013 00:20:00 -0500 Received: from server.prisktech.co.nz ([115.188.14.127]:59069 "EHLO server.prisktech.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964Ab3AOFT7 (ORCPT ); Tue, 15 Jan 2013 00:19:59 -0500 Message-ID: <1358227220.5928.2.camel@gitbox> Subject: Re: [PATCH v2] gpio: vt8500: memory cleanup missing From: Tony Prisk To: Grant Likely Cc: Linux Walleij , vt8500-wm8505-linux-kernel@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk Date: Tue, 15 Jan 2013 18:20:20 +1300 In-Reply-To: <1358188644-23838-1-git-send-email-linux@prisktech.co.nz> References: <1358188644-23838-1-git-send-email-linux@prisktech.co.nz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-01-15 at 07:37 +1300, Tony Prisk wrote: > This driver is missing a .remove callback, and the fail path on > probe is incomplete. > > If an error occurs in vt8500_add_chips, gpio_base is not unmapped. > The driver is also ignoring the return value from this function so > if a chip fails to register it completes as successful. > > Replaced pr_err with dev_err in vt8500_add_chips since the device is > available. > > There is also no .remove callback defined. To allow removing the > registered chips, I have moved *vtchip to be a static global. > > Signed-off-by: Tony Prisk > --- > Hi Grant, > > Let me know what you think of these changes. > > v2: > Removed unnecessary whitespace change. > Removed test against pdev->dev.of_node (np). Replaced code with a > devm_request_and_ioremap so np is now unneccessary. This also removes the need > for cleanup in the fail path. > Move struct vt8500_gpio_chip within vt8500_data and store the iobase and > num_banks in vt8500_data. > Grant, If there are no further changes for this patch, would you mind correcting the commit message when you merge it? -There is also no .remove callback defined. To allow removing the -Registered chips, I have moved *vtchip to be a static global. + There is also no .remove callback defined. Otherwise, I will fix it along with whatever other comments come in. Regards Tony P