From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933707Ab3AOXaZ (ORCPT ); Tue, 15 Jan 2013 18:30:25 -0500 Received: from server.prisktech.co.nz ([115.188.14.127]:58592 "EHLO server.prisktech.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932879Ab3AOXaT (ORCPT ); Tue, 15 Jan 2013 18:30:19 -0500 Message-ID: <1358292641.11794.1.camel@gitbox> Subject: Re: [PATCH v2] mtd: vt8500: Add support for Wondermedia Serial Flash Controller From: Tony Prisk To: dedekind1@gmail.com Cc: David Woodhouse , vt8500-wm8505-linux-kernel@googlegroups.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Wed, 16 Jan 2013 12:30:41 +1300 In-Reply-To: <1358277072.1668.2.camel@kyv> References: <1356901207-13536-1-git-send-email-linux@prisktech.co.nz> <1358261750.2731.148.camel@sauron.fi.intel.com> <1358271907.31593.1.camel@gitbox> <1358277072.1668.2.camel@kyv> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-01-15 at 21:11 +0200, Artem Bityutskiy wrote: > On Wed, 2013-01-16 at 06:45 +1300, Tony Prisk wrote: > > On Tue, 2013-01-15 at 16:55 +0200, Artem Bityutskiy wrote: > > > On Mon, 2012-12-31 at 10:00 +1300, Tony Prisk wrote: > > > > This patch adds support for the Wondermedia serial flash controller > > > > found on WM8505, WM8650 and WM8850 SoCs. > > > > > > > > Signed-off-by: Tony Prisk > > > > --- > > > > v2: Whitespace tidyup > > > > > > Hi, would you please take a look at these warings, identified by aiaiai: > > > > > > Successfully built configuration "x86_64_defconfig,x86_64,", results: > > > > > > --- before_patching.log > > > +++ after_patching.log > > > @@ @@ > > > +drivers/mtd/devices/wmt_sflash.c: In function ‘sf_read’: > > > +drivers/mtd/devices/wmt_sflash.c:425:9: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat] > > > +drivers/mtd/devices/wmt_sflash.c: In function ‘sf_sector_write’: > > > +drivers/mtd/devices/wmt_sflash.c:442:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > > > +drivers/mtd/devices/wmt_sflash.c:442:24: warning: cast removes address space of expression [sparse] > > > +drivers/mtd/devices/wmt_sflash.c:458:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > > +drivers/mtd/devices/wmt_sflash.c:458:31: warning: incorrect type in argument 1 (different address spaces) [sparse] > > > +drivers/mtd/devices/wmt_sflash.c:458:31: expected void volatile [noderef] *dst [sparse] > > > +drivers/mtd/devices/wmt_sflash.c:458:31: got unsigned char [usertype] * [sparse] > > > +drivers/mtd/devices/wmt_sflash.c:465:17: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > > +drivers/mtd/devices/wmt_sflash.c:465:39: warning: incorrect type in argument 1 (different address spaces) [sparse] > > > +drivers/mtd/devices/wmt_sflash.c:465:39: expected void volatile [noderef] *dst [sparse] > > > +drivers/mtd/devices/wmt_sflash.c:465:39: got unsigned char [usertype] * [sparse] > > > > > > > Apologies - This driver shouldn't be selectable for x86_64. > > It is an ARM driver for an embedded device. Will fix. > > Note, there are also warnings when it is compiled for other platforms, > not only x86_64. Take a look at them. Also note, than many warnings come > from sparse, you probably just did not run it. > I posted the patch for this problem this morning. It should only be selectable on arch-vt8500 and the new patch fixes this problem. It incorrectly depended on MTD rather than ARCH_VT8500 Regards Tony P