* [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller
@ 2012-12-12 5:07 chao bi
2013-01-16 2:50 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: chao bi @ 2012-12-12 5:07 UTC (permalink / raw)
To: Alan Cox; +Cc: richardx.r.gorby, jun.d.chen, linux-serial, linux-kernel
As protocol driver, IFX SPI driver initiate to setup SPI master with default
SPI word size as 16 bit/word, however, SPI master may not adopt this default
value due to SPI controller's capability, it might choose an available value by
itself and set it to spi_device.bits_per_word. In order to keep align with
Controller, IFX driver should make use of this value during SPI transfer,
but the default one.
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
Signed-off-by: channing <chao.bi@intel.com>
---
drivers/tty/serial/ifx6x60.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 675d94a..5919992 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -810,7 +810,8 @@ static void ifx_spi_io(unsigned long data)
ifx_dev->spi_xfer.cs_change = 0;
ifx_dev->spi_xfer.speed_hz = ifx_dev->spi_dev->max_speed_hz;
/* ifx_dev->spi_xfer.speed_hz = 390625; */
- ifx_dev->spi_xfer.bits_per_word = spi_bpw;
+ ifx_dev->spi_xfer.bits_per_word =
+ ifx_dev->spi_dev->bits_per_word;
ifx_dev->spi_xfer.tx_buf = ifx_dev->tx_buffer;
ifx_dev->spi_xfer.rx_buf = ifx_dev->rx_buffer;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller
2012-12-12 5:07 chao bi
@ 2013-01-16 2:50 ` Greg KH
2013-01-16 4:57 ` Bi, Chao
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2013-01-16 2:50 UTC (permalink / raw)
To: chao bi; +Cc: Alan Cox, richardx.r.gorby, jun.d.chen, linux-serial,
linux-kernel
On Wed, Dec 12, 2012 at 01:07:06PM +0800, chao bi wrote:
>
> As protocol driver, IFX SPI driver initiate to setup SPI master with default
> SPI word size as 16 bit/word, however, SPI master may not adopt this default
> value due to SPI controller's capability, it might choose an available value by
> itself and set it to spi_device.bits_per_word. In order to keep align with
> Controller, IFX driver should make use of this value during SPI transfer,
> but the default one.
>
> Signed-off-by: Chen Jun <jun.d.chen@intel.com>
> Signed-off-by: channing <chao.bi@intel.com>
> ---
> drivers/tty/serial/ifx6x60.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
> index 675d94a..5919992 100644
> --- a/drivers/tty/serial/ifx6x60.c
> +++ b/drivers/tty/serial/ifx6x60.c
> @@ -810,7 +810,8 @@ static void ifx_spi_io(unsigned long data)
> ifx_dev->spi_xfer.cs_change = 0;
> ifx_dev->spi_xfer.speed_hz = ifx_dev->spi_dev->max_speed_hz;
> /* ifx_dev->spi_xfer.speed_hz = 390625; */
> - ifx_dev->spi_xfer.bits_per_word = spi_bpw;
> + ifx_dev->spi_xfer.bits_per_word =
> + ifx_dev->spi_dev->bits_per_word;
Please follow the proper coding style (hint, this isn't it.)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller
2013-01-16 2:50 ` Greg KH
@ 2013-01-16 4:57 ` Bi, Chao
0 siblings, 0 replies; 4+ messages in thread
From: Bi, Chao @ 2013-01-16 4:57 UTC (permalink / raw)
To: Greg KH
Cc: Alan Cox, Gorby, Russ, Chen, Jun D, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Sorry for that, please check my resubmitted patch right now.
Thanks,
Chao
-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org]
Sent: Wednesday, January 16, 2013 10:50 AM
To: Bi, Chao
Cc: Alan Cox; Gorby, Russ; Chen, Jun D; linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller
On Wed, Dec 12, 2012 at 01:07:06PM +0800, chao bi wrote:
>
> As protocol driver, IFX SPI driver initiate to setup SPI master with
> default SPI word size as 16 bit/word, however, SPI master may not
> adopt this default value due to SPI controller's capability, it might
> choose an available value by itself and set it to
> spi_device.bits_per_word. In order to keep align with Controller, IFX
> driver should make use of this value during SPI transfer, but the default one.
>
> Signed-off-by: Chen Jun <jun.d.chen@intel.com>
> Signed-off-by: channing <chao.bi@intel.com>
> ---
> drivers/tty/serial/ifx6x60.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/ifx6x60.c
> b/drivers/tty/serial/ifx6x60.c index 675d94a..5919992 100644
> --- a/drivers/tty/serial/ifx6x60.c
> +++ b/drivers/tty/serial/ifx6x60.c
> @@ -810,7 +810,8 @@ static void ifx_spi_io(unsigned long data)
> ifx_dev->spi_xfer.cs_change = 0;
> ifx_dev->spi_xfer.speed_hz = ifx_dev->spi_dev->max_speed_hz;
> /* ifx_dev->spi_xfer.speed_hz = 390625; */
> - ifx_dev->spi_xfer.bits_per_word = spi_bpw;
> + ifx_dev->spi_xfer.bits_per_word =
> + ifx_dev->spi_dev->bits_per_word;
Please follow the proper coding style (hint, this isn't it.)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller
@ 2013-01-16 5:14 channing
0 siblings, 0 replies; 4+ messages in thread
From: channing @ 2013-01-16 5:14 UTC (permalink / raw)
To: alan; +Cc: greg, richardx.r.gorby, jun.d.chen, linux-serial, linux-kernel
As protocol driver, IFX SPI driver initiate to setup SPI master with default
SPI word size as 16 bit/word, however, SPI master may not adopt this default
value due to SPI controller's capability, it might choose an available value by
itself and set it to spi_device.bits_per_word. In order to keep align with
Controller, IFX driver should make use of this value during SPI transfer,
but the default one.
Signed-off-by: Chen Jun <jun.d.chen@intel.com>
Signed-off-by: channing <chao.bi@intel.com>
---
drivers/tty/serial/ifx6x60.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 675d94a..3e337b8 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -810,7 +810,8 @@ static void ifx_spi_io(unsigned long data)
ifx_dev->spi_xfer.cs_change = 0;
ifx_dev->spi_xfer.speed_hz = ifx_dev->spi_dev->max_speed_hz;
/* ifx_dev->spi_xfer.speed_hz = 390625; */
- ifx_dev->spi_xfer.bits_per_word = spi_bpw;
+ ifx_dev->spi_xfer.bits_per_word =
+ ifx_dev->spi_dev->bits_per_word;
ifx_dev->spi_xfer.tx_buf = ifx_dev->tx_buffer;
ifx_dev->spi_xfer.rx_buf = ifx_dev->rx_buffer;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-16 4:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 5:14 [PATCH] serial:ifx6x60:Keep word size accordance with SPI controller channing
-- strict thread matches above, loose matches on Subject: below --
2012-12-12 5:07 chao bi
2013-01-16 2:50 ` Greg KH
2013-01-16 4:57 ` Bi, Chao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).