Re: [PATCH] rtc: hid-sensor-time: Add missing spin_lock_init

Thiago Farina
2013-01-17T02:04:43Z

On Wed, Jan 16, 2013 at 11:49 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/rtc/rtc-hid-sensor-time.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-hid-sensor-time.c b/drivers/rtc/rtc-hid-sensor-time.c
> index 0438c9e..31c5728 100644
> --- a/drivers/rtc/rtc-hid-sensor-time.c
> +++ b/drivers/rtc/rtc-hid-sensor-time.c
> @@ -225,6 +225,7 @@ static int hid_time_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, time_state);
>
> + spin_lock_init(&time_state->lock_last_time);
Can you explain in the commit message why it is missing?

For people not familiar with this code that isn't obvious.