From: Shuah Khan <shuah.khan@hp.com>
To: Ilija Hadzic <ihadzic@research.bell-labs.com>
Cc: airlied@linux.ie, deathsimple@vodafone.de, jglisse@redhat.com,
airlied@redhat.com, "Deucher,
Alexander" <alexander.deucher@amd.com>,
Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, shuahkhan@gmail.com
Subject: Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()
Date: Thu, 17 Jan 2013 10:09:42 -0700 [thread overview]
Message-ID: <1358442582.2828.11.camel@lorien2> (raw)
In-Reply-To: <Pine.GSO.4.64.1301162045321.898@umail>
On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote:
> Actually, the code path affected by your patch is not executed in UMS mode
> at all. Notice that radeon_cs_parser_fini is only called from
> radeon_cs_ioctl which is a KMS-only ioctl (see radeon_kms.c).
>
> The equivalent of the fix you are trying to do is in
> a6b7e1a02b77ab8fe8775d20a88c53d8ba55482e (function patched by that one is
> the one used by legacy-CS ioctl), which you should go together
> with ff4bd0827764e10a428a9d39e6814c5478863f94 if you are backporting UMS
> fixes to 3.7. Both are needed to prevent kernel crashes in UMS mode.
>
> -- Ilija
Thanks. I will take a look at a6b7e1a02b77ab8fe8775d20a88c53d8ba55482e.
I sent back-ported ff4bd0827764e10a428a9d39e6814c5478863f94 patch to
stable and I will back-port and send
a6b7e1a02b77ab8fe8775d20a88c53d8ba55482e as well.
-- Shuah
next prev parent reply other threads:[~2013-01-17 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 23:43 [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini() Shuah Khan
2013-01-17 3:06 ` Ilija Hadzic
2013-01-17 17:09 ` Shuah Khan [this message]
2013-01-23 16:07 ` Herton Ronaldo Krzesinski
2013-01-23 17:21 ` Ilija Hadzic
2013-01-23 17:40 ` Herton Ronaldo Krzesinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358442582.2828.11.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=ihadzic@research.bell-labs.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox