From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] f2fs: use _safe() version of list_for_each
Date: Mon, 21 Jan 2013 18:20:01 +0900 [thread overview]
Message-ID: <1358760001.8234.150.camel@kjgkr> (raw)
In-Reply-To: <20130121083245.GA11592@core.coreip.homeip.net>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
2013-01-21 (월), 00:32 -0800, Dmitry Torokhov:
> On Sun, Jan 20, 2013 at 06:02:58PM +0300, Dan Carpenter wrote:
> > This is calling list_del() inside a loop which is a problem when we try
> > move to the next item on the list. I've converted it to use the _safe
> > version. And also, as a cleanup, I've converted it to use
> > list_for_each_entry instead of list_for_each.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Static analysis stuff. Untested. Please review carefully.
>
> Makes sense to me.
>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
No doubt, applied.
Thanks,
--
Jaegeuk Kim
Samsung
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-21 9:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 15:02 [patch] f2fs: use _safe() version of list_for_each Dan Carpenter
2013-01-21 0:39 ` Namjae Jeon
2013-01-21 8:25 ` Dan Carpenter
2013-01-21 8:34 ` Dmitry Torokhov
2013-01-21 8:32 ` Dmitry Torokhov
2013-01-21 9:20 ` Jaegeuk Kim [this message]
2013-01-21 10:27 ` Namjae Jeon
2013-01-21 10:37 ` Julia Lawall
2013-01-21 11:24 ` Dan Carpenter
2013-01-21 12:04 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358760001.8234.150.camel@kjgkr \
--to=jaegeuk.kim@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox