From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 04/19] perf report: Make another loop for linking group hists
Date: Tue, 22 Jan 2013 18:09:32 +0900 [thread overview]
Message-ID: <1358845787-1350-5-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1358845787-1350-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
Now the event grouping viewing requires linking all member hists in a
group to the leader's. Thus hists__output_resort should be called after
linking all events in evlist.
Introduce symbol_conf.event_group flag to determine whether the feature
is enabled or not.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1355726345-29553-6-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-report.c | 13 ++++++++++++-
tools/perf/util/symbol.h | 3 ++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 47a864478543..fd2503a5f876 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -416,8 +416,16 @@ static int __cmd_report(struct perf_report *rep)
hists->symbol_filter_str = rep->symbol_filter_str;
hists__collapse_resort(hists);
- hists__output_resort(hists);
nr_samples += hists->stats.nr_events[PERF_RECORD_SAMPLE];
+
+ /* Non-group events are considered as leader */
+ if (symbol_conf.event_group &&
+ !perf_evsel__is_group_leader(pos)) {
+ struct hists *leader_hists = &pos->leader->hists;
+
+ hists__match(leader_hists, hists);
+ hists__link(leader_hists, hists);
+ }
}
if (nr_samples == 0) {
@@ -425,6 +433,9 @@ static int __cmd_report(struct perf_report *rep)
goto out_delete;
}
+ list_for_each_entry(pos, &session->evlist->entries, node)
+ hists__output_resort(&pos->hists);
+
if (use_browser > 0) {
if (use_browser == 1) {
perf_evlist__tui_browse_hists(session->evlist, help,
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
index d97377ac2f16..b62ca37c4b77 100644
--- a/tools/perf/util/symbol.h
+++ b/tools/perf/util/symbol.h
@@ -96,7 +96,8 @@ struct symbol_conf {
initialized,
kptr_restrict,
annotate_asm_raw,
- annotate_src;
+ annotate_src,
+ event_group;
const char *vmlinux_name,
*kallsyms_name,
*source_prefix,
--
1.7.11.7
next prev parent reply other threads:[~2013-01-22 9:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 9:09 [PATCH 00/19] perf report: Add support for event group view (v9) Namhyung Kim
2013-01-22 9:09 ` [PATCH 01/19] perf tools: Keep group information Namhyung Kim
2013-02-01 10:38 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 02/19] perf tests: Add group test conditions Namhyung Kim
2013-02-01 10:39 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 03/19] perf header: Add HEADER_GROUP_DESC feature Namhyung Kim
2013-02-01 10:40 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` Namhyung Kim [this message]
2013-02-01 10:41 ` [tip:perf/core] perf report: Make another loop for linking group hists tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 05/19] perf hists: Resort hist entries using group members for output Namhyung Kim
2013-02-01 10:42 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 06/19] perf ui/hist: Consolidate hpp helpers Namhyung Kim
2013-02-01 10:43 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 07/19] perf hist browser: Convert hpp helpers to a function Namhyung Kim
2013-02-01 10:45 ` [tip:perf/core] perf hists " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 08/19] perf gtk/browser: " Namhyung Kim
2013-02-01 10:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 09/19] perf ui/hist: Add support for event group view Namhyung Kim
2013-02-01 10:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 10/19] perf hist browser: Move coloring logic to hpp functions Namhyung Kim
2013-02-01 10:48 ` [tip:perf/core] perf hists " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 11/19] perf hist browser: Add suppport for event group view Namhyung Kim
2013-02-01 10:49 ` [tip:perf/core] perf hists " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 12/19] perf gtk/browser: Add support " Namhyung Kim
2013-02-01 10:51 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 13/19] perf tools: Move ltrim() to util/string.c Namhyung Kim
2013-01-25 11:58 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 14/19] perf gtk/browser: Trim column header string when event group enabled Namhyung Kim
2013-02-01 10:52 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 15/19] perf report: Bypass non-leader events when event group is enabled Namhyung Kim
2013-02-01 10:53 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 16/19] perf report: Show group description " Namhyung Kim
2013-02-01 10:54 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 17/19] perf report: Add --group option Namhyung Kim
2013-02-01 10:55 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 18/19] perf report: Add report.group config option Namhyung Kim
2013-02-01 10:56 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-01-22 9:09 ` [PATCH 19/19] perf evlist: Add --group option Namhyung Kim
2013-02-01 10:58 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358845787-1350-5-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox