From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753977Ab3AWHtz (ORCPT ); Wed, 23 Jan 2013 02:49:55 -0500 Received: from mail-ea0-f182.google.com ([209.85.215.182]:60777 "EHLO mail-ea0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191Ab3AWHtx (ORCPT ); Wed, 23 Jan 2013 02:49:53 -0500 From: Christian Gmeiner To: linux-next@vger.kernel.org, akpm@linux-foundation.org, rpurdie@rpsys.net, linux-kernel@vger.kernel.org, c.gmeiner@bachmann.info Cc: Christian Gmeiner Subject: [PATCH] leds-ot200: Fix error caused by shifted mask Date: Wed, 23 Jan 2013 09:10:56 +0100 Message-Id: <1358928657-15781-1-git-send-email-christian.gmeiner@gmail.com> X-Mailer: git-send-email 1.7.12.2.421.g261b511 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During the development of this driver an in-house register documentation was used. The last weeks some integration tests were done and this problem was found. It turned out that the released register documentation is wrong. The fix is very simple: shift all masks by one. Signed-off-by: Christian Gmeiner --- drivers/leds/leds-ot200.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c index ee14662..98cae52 100644 --- a/drivers/leds/leds-ot200.c +++ b/drivers/leds/leds-ot200.c @@ -47,37 +47,37 @@ static struct ot200_led leds[] = { { .name = "led_1", .port = 0x49, - .mask = BIT(7), + .mask = BIT(6), }, { .name = "led_2", .port = 0x49, - .mask = BIT(6), + .mask = BIT(5), }, { .name = "led_3", .port = 0x49, - .mask = BIT(5), + .mask = BIT(4), }, { .name = "led_4", .port = 0x49, - .mask = BIT(4), + .mask = BIT(3), }, { .name = "led_5", .port = 0x49, - .mask = BIT(3), + .mask = BIT(2), }, { .name = "led_6", .port = 0x49, - .mask = BIT(2), + .mask = BIT(1), }, { .name = "led_7", .port = 0x49, - .mask = BIT(1), + .mask = BIT(0), } }; -- 1.7.12.2.421.g261b511