Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context

gregkh
2013-01-24T17:17:45Z

On Thu, Jan 24, 2013 at 05:06:27PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Jiri Kosina [mailto:jkosina@suse.cz]
> > Sent: Thursday, January 24, 2013 5:10 AM
> > To: KY Srinivasan
> > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > jasowang@redhat.com; davem@davemloft.net;
> > James.Bottomley@HansenPartnership.com
> > Subject: Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context
> >
> > On Wed, 23 Jan 2013, K. Y. Srinivasan wrote:
> >
> > > Execute the shutdown code in a thread context. With recent changes made to
> > the
> > > shutdown code, shutdown code cannot be invoked from an interrupt context.
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > ---
> > > drivers/hv/hv_util.c | 12 +++++++++++-
> > > 1 files changed, 11 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> > > index 8b7868a..aceb67f 100644
> > > --- a/drivers/hv/hv_util.c
> > > +++ b/drivers/hv/hv_util.c
> > > @@ -49,6 +49,16 @@ static struct hv_util_service util_kvp = {
> > > .util_deinit = hv_kvp_deinit,
> > > };
> > >
> > > +static void perform_shutdown(struct work_struct *dummy)
> > > +{
> > > + orderly_poweroff(true);
> > > +}
> >
> > Is there any particular reason for this kind of crazy indentation?
> I don't know how this extra tab crept through! Greg, if you want I can resend
> this patch minus the extra tab. Let me know.

I'll edit it by hand, but someone owes me a beer for it... :)

greg k-h