Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context

gregkh
2013-03-01T16:11:30Z

On Fri, Mar 01, 2013 at 03:15:58PM +0000, KY Srinivasan wrote:
> > > > > Execute the shutdown code in a thread context. With recent changes made
> > > > the
> > > > > shutdown code, shutdown code cannot be invoked from an interrupt
> > context.
> > > > >
> > > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > > > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> > > > > ---
> > > > > drivers/hv/hv_util.c | 12 +++++++++++-
> > > > > 1 files changed, 11 insertions(+), 1 deletions(-)
> > > > >
> > > > > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> > > > > index 8b7868a..aceb67f 100644
> > > > > --- a/drivers/hv/hv_util.c
> > > > > +++ b/drivers/hv/hv_util.c
> > > > > @@ -49,6 +49,16 @@ static struct hv_util_service util_kvp = {
> > > > > .util_deinit = hv_kvp_deinit,
> > > > > };
> > > > >
> > > > > +static void perform_shutdown(struct work_struct *dummy)
> > > > > +{
> > > > > + orderly_poweroff(true);
> > > > > +}
> > > >
> > > > Is there any particular reason for this kind of crazy indentation?
> > > I don't know how this extra tab crept through! Greg, if you want I can resend
> > > this patch minus the extra tab. Let me know.
> >
> > I'll edit it by hand, but someone owes me a beer for it... :)
>
> Greg,
>
> You have already applied this. There has been some customer request for getting this
> patch into 3.7 (3.7 is where the Hyper-V shutdown code ceased to work because of
> some other patches unrelated to Hyper-V that went in). What is the process for requesting
> that this patch be applied all the way back to 3.7.

You have read the file, Documentation/stable_kernel_rules.txt, right?

But please remember, the 3.7 kernel is now end-of-life, as of the 3.7.10
kernel release, so even if this was a bug fix that was applicable to
stable kernels, it would be impossible to get it into the 3.7.y
releases, without going back in time.

sorry,

greg k-h