Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

Stephen Warren
2013-01-25T04:55:37Z

On 01/24/2013 06:20 PM, Axel Lin wrote:
> The dev parameter is the device requesting the data.
> In this case it should be &pdev->dev rather than pdev->dev.parent.
>
> The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
> which means this fixes a memory leak because the memory is allocated every time
> probe() is called, thus it should be freed when this driver is unloaded.

Reviewed-by: Stephen Warren <swarren@nvidia.com>