From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 05/10] mfd: arizona: Check errors from regcache_sync()
Date: Sun, 27 Jan 2013 12:07:27 +0800 [thread overview]
Message-ID: <1359259652-8565-5-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1359259652-8565-1-git-send-email-broonie@opensource.wolfsonmicro.com>
If the control bus is unrelabile we may hit errors during regcache_sync(),
especially given that it tends to be one the most dense bursts of I/O in
many systems.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index a8b8a7b..1ab02a7 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -239,7 +239,12 @@ static int arizona_runtime_resume(struct device *dev)
return ret;
}
- regcache_sync(arizona->regmap);
+ ret = regcache_sync(arizona->regmap);
+ if (ret != 0) {
+ dev_err(arizona->dev, "Failed to restore register cache\n");
+ regulator_disable(arizona->dcvdd);
+ return ret;
+ }
return 0;
}
--
1.7.10.4
next prev parent reply other threads:[~2013-01-27 4:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 4:07 [PATCH 01/10] mfd: wm5102: Mark DSP memory regions as volatile and readable Mark Brown
2013-01-27 4:07 ` [PATCH 02/10] mfd: wm5102: Mark only extant DSP registers volatile Mark Brown
2013-01-27 4:07 ` [PATCH 03/10] mfd: arizona: Register MICVDD supply first to ensure no retries Mark Brown
2013-01-27 4:07 ` [PATCH 04/10] mfd: arizona: Disable control interface reporting for WM5102 and WM5110 Mark Brown
2013-01-27 4:07 ` Mark Brown [this message]
2013-01-27 4:07 ` [PATCH 06/10] mfd: arizona: Allow customisation of microphone detection levels Mark Brown
2013-01-27 9:44 ` Mark Brown
2013-01-27 23:56 ` Samuel Ortiz
2013-01-27 4:07 ` [PATCH 07/10] mfd: wm5102: Add registers for microphone detection level configuration Mark Brown
2013-02-03 17:00 ` Samuel Ortiz
2013-01-27 4:07 ` [PATCH 08/10] mfd: wm5102: Refresh register defaults Mark Brown
2013-02-03 17:00 ` Samuel Ortiz
2013-01-27 4:07 ` [PATCH 09/10] mfd: wm5102: Update rev B patch for latest evaluation Mark Brown
2013-01-27 4:07 ` [PATCH 10/10] mfd: arizona: Disable interrupts during resume Mark Brown
2013-02-03 17:00 ` [PATCH 01/10] mfd: wm5102: Mark DSP memory regions as volatile and readable Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359259652-8565-5-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox