From: Hannes Reinecke <hare@suse.de>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, Stefan Weinhuber <wein@de.ibm.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 5/9] dasd: Reduce amount of messages for specific errors
Date: Tue, 29 Jan 2013 08:11:57 +0100 [thread overview]
Message-ID: <1359443521-24670-6-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1359443521-24670-1-git-send-email-hare@suse.de>
Whenever a request has been aborted internally by the driver
there is no sense data to be had. And printing lots of messages
stalls the system, so better to print out a short one-liner.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/s390/block/dasd_erp.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/s390/block/dasd_erp.c b/drivers/s390/block/dasd_erp.c
index d01ef82..908b9a0 100644
--- a/drivers/s390/block/dasd_erp.c
+++ b/drivers/s390/block/dasd_erp.c
@@ -159,6 +159,14 @@ dasd_log_sense(struct dasd_ccw_req *cqr, struct irb *irb)
struct dasd_device *device;
device = cqr->startdev;
+ if (cqr->intrc == -ETIMEDOUT) {
+ dev_err(&device->cdev->dev, "cqr %p timeout error", cqr);
+ return;
+ }
+ if (cqr->intrc == -ENOLINK) {
+ dev_err(&device->cdev->dev, "cqr %p transport error", cqr);
+ return;
+ }
/* dump sense data */
if (device->discipline && device->discipline->dump_sense)
device->discipline->dump_sense(device, cqr, irb);
--
1.7.4.2
next prev parent reply other threads:[~2013-01-29 7:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 7:11 [PATCH 0/9] dasd: implement block timeout Hannes Reinecke
2013-01-29 7:11 ` [PATCH 1/9] dasd: Clarify comment Hannes Reinecke
2013-01-29 7:11 ` [PATCH 2/9] dasd: make number of retries configurable Hannes Reinecke
2013-01-29 7:11 ` [PATCH 3/9] dasd: process all requests in the device tasklet Hannes Reinecke
2013-01-29 7:11 ` [PATCH 4/9] dasd: Implement block timeout handling Hannes Reinecke
2013-01-29 11:32 ` Heiko Carstens
2013-01-29 11:34 ` Hannes Reinecke
2013-01-29 7:11 ` Hannes Reinecke [this message]
2013-01-29 7:11 ` [PATCH 6/9] dasd: detailed I/O errors Hannes Reinecke
2013-01-29 7:11 ` [PATCH 7/9] block: check for timeout function in blk_rq_timed_out() Hannes Reinecke
2013-01-29 7:12 ` [PATCH 8/9] dasd: Add 'timeout' attribute Hannes Reinecke
2013-01-29 11:36 ` Heiko Carstens
2013-01-29 11:41 ` Hannes Reinecke
2013-01-29 15:17 ` Stefan Weinhuber
2013-01-29 15:27 ` Hannes Reinecke
2013-01-29 7:12 ` [PATCH 9/9] dasd: Fail all requests when DASD_FLAG_ABORTIO is set Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2013-01-30 9:26 [PATCH 0/9][v2] dasd: implement block timeout Hannes Reinecke
2013-01-30 9:26 ` [PATCH 5/9] dasd: Reduce amount of messages for specific errors Hannes Reinecke
2013-06-03 15:03 [PATCH 0/9] dasd: implement block timeout Martin Schwidefsky
2013-06-03 15:03 ` [PATCH 5/9] dasd: Reduce amount of messages for specific errors Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359443521-24670-6-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=wein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).