* [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static
@ 2013-01-29 9:40 Sachin Kamat
2013-01-29 9:40 ` [PATCH 2/3] extcon: max8997: Remove unreachable code Sachin Kamat
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-01-29 9:40 UTC (permalink / raw)
To: linux-kernel; +Cc: cw00.choi, myungjoo.ham, sachin.kamat, dg77.kim
'max8997_extcon_cable' is used only in this file. Hence make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/extcon/extcon-max8997.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index df9358e..7039541 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -109,7 +109,7 @@ struct max8997_muic_info {
struct extcon_dev *edev;
};
-const char *max8997_extcon_cable[] = {
+static const char *max8997_extcon_cable[] = {
[0] = "USB",
[1] = "USB-Host",
[2] = "TA",
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/3] extcon: max8997: Remove unreachable code
2013-01-29 9:40 [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static Sachin Kamat
@ 2013-01-29 9:40 ` Sachin Kamat
2013-01-29 9:40 ` [PATCH 3/3] extcon: max77693: Make max77693_extcon_cable static Sachin Kamat
2013-02-04 1:11 ` [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static Chanwoo Choi
2 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-01-29 9:40 UTC (permalink / raw)
To: linux-kernel; +Cc: cw00.choi, myungjoo.ham, sachin.kamat, dg77.kim
'break' after 'return' is never executed and hence can be deleted.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/extcon/extcon-max8997.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 7039541..d16090d 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -289,7 +289,6 @@ static int max8997_muic_handle_charger_type_detach(
break;
default:
return -EINVAL;
- break;
}
return 0;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] extcon: max77693: Make max77693_extcon_cable static
2013-01-29 9:40 [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static Sachin Kamat
2013-01-29 9:40 ` [PATCH 2/3] extcon: max8997: Remove unreachable code Sachin Kamat
@ 2013-01-29 9:40 ` Sachin Kamat
2013-02-04 1:11 ` [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static Chanwoo Choi
2 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-01-29 9:40 UTC (permalink / raw)
To: linux-kernel; +Cc: cw00.choi, myungjoo.ham, sachin.kamat, dg77.kim
'max77693_extcon_cable' is used only in this file. Hence
make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/extcon/extcon-max77693.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
index fb65276..a645268 100644
--- a/drivers/extcon/extcon-max77693.c
+++ b/drivers/extcon/extcon-max77693.c
@@ -185,7 +185,7 @@ enum {
_EXTCON_CABLE_NUM,
};
-const char *max77693_extcon_cable[] = {
+static const char *max77693_extcon_cable[] = {
[EXTCON_CABLE_USB] = "USB",
[EXTCON_CABLE_USB_HOST] = "USB-Host",
[EXTCON_CABLE_TA] = "TA",
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static
2013-01-29 9:40 [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static Sachin Kamat
2013-01-29 9:40 ` [PATCH 2/3] extcon: max8997: Remove unreachable code Sachin Kamat
2013-01-29 9:40 ` [PATCH 3/3] extcon: max77693: Make max77693_extcon_cable static Sachin Kamat
@ 2013-02-04 1:11 ` Chanwoo Choi
2 siblings, 0 replies; 4+ messages in thread
From: Chanwoo Choi @ 2013-02-04 1:11 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, myungjoo.ham
On 01/29/2013 06:40 PM, Sachin Kamat wrote:
> 'max8997_extcon_cable' is used only in this file. Hence make it static.
>
> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
> ---
> drivers/extcon/extcon-max8997.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index df9358e..7039541 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -109,7 +109,7 @@ struct max8997_muic_info {
> struct extcon_dev *edev;
> };
>
> -const char *max8997_extcon_cable[] = {
> +static const char *max8997_extcon_cable[] = {
> [0] = "USB",
> [1] = "USB-Host",
> [2] = "TA",
Patches 1-3 applied.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-04 1:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-29 9:40 [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static Sachin Kamat
2013-01-29 9:40 ` [PATCH 2/3] extcon: max8997: Remove unreachable code Sachin Kamat
2013-01-29 9:40 ` [PATCH 3/3] extcon: max77693: Make max77693_extcon_cable static Sachin Kamat
2013-02-04 1:11 ` [PATCH 1/3] extcon: max8997: Make max8997_extcon_cable static Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).