[PATCH 2/4] pps: Don't crash the machine when exiting will do

Peter Hurley
2013-02-06T15:57:06Z

PPS is not really the must-have subsystem that warrants crashing
the machine if the ldisc interface is broken.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
drivers/pps/clients/pps-ldisc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pps/clients/pps-ldisc.c b/drivers/pps/clients/pps-ldisc.c
index 27d7ca1..0b91d91 100644
--- a/drivers/pps/clients/pps-ldisc.c
+++ b/drivers/pps/clients/pps-ldisc.c
@@ -25,6 +25,7 @@
#include <linux/serial_core.h>
#include <linux/tty.h>
#include <linux/pps_kernel.h>
+#include <linux/bug.h>

#define PPS_TTY_MAGIC 0x0001

@@ -35,7 +36,8 @@ static void pps_tty_dcd_change(struct tty_struct *tty, unsigned int status)

pps_get_ts(&ts);

- BUG_ON(pps == NULL);
+ if (WARN_ON_ONCE(pps == NULL))
+ return;

/* Now do the PPS event report */
pps_event(pps, &ts, status ? PPS_CAPTUREASSERT :
--
1.8.1.2