From: Pawel Moll <pawel.moll@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: John Stultz <john.stultz@linaro.org>,
Stephane Eranian <eranian@google.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Will Deacon <Will.Deacon@arm.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
Pekka Enberg <penberg@gmail.com>,
Robert Richter <robert.richter@amd.com>,
tglx <tglx@linutronix.de>
Subject: Re: [RFC] perf: need to expose sched_clock to correlate user samples with kernel samples
Date: Wed, 06 Feb 2013 18:17:37 +0000 [thread overview]
Message-ID: <1360174657.4045.33.camel@hornet> (raw)
In-Reply-To: <1360113595.2621.30.camel@gandalf.local.home>
On Wed, 2013-02-06 at 01:19 +0000, Steven Rostedt wrote:
> If people are worried about adding a bunch of new perf syscalls, maybe
> add a sys_perf_control() system call that works like an ioctl but
> without a file descriptor. Something for things that don't require an
> event attached to it, like to retrieve a time stamp counter that perf
> uses, but done in a way that it could be used for other things perf
> related that does not require an event.
Something along these lines? (completely untested and of course missing
all the #defines __NR_perf_control xxx)
8<-----------------
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 4f63c05..be7409b 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -322,6 +322,11 @@ enum perf_event_ioc_flags {
};
/*
+ * Command codes for ioctl-like sys_perf_control interface:
+ */
+#define PERF_CONTROL_GET_TIME _IOR('$', 0, __u64)
+
+/*
* Structure of the page that can be mapped via mmap
*/
struct perf_event_mmap_page {
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 301079d..750404d 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6678,6 +6678,29 @@ err_fd:
}
/**
+ * sys_perf_control - ioctl-like interface to control system-wide
+ * perf behaviour
+ *
+ * @cmd: one of the PERF_CONTROL_* commands
+ * @arg: command-specific argument
+ */
+SYSCALL_DEFINE2(perf_control, unsigned int, cmd, unsigned long, arg)
+{
+ switch (cmd) {
+ case PERF_CONTROL_GET_TIME:
+ {
+ u64 time = perf_clock();
+ if (copy_to_user((void __user *)arg, &time, sizeof(time)))
+ return -EFAULT;
+ return 0;
+ }
+
+ default:
+ return -ENOTTY;
+ }
+}
+
+/**
* perf_event_create_kernel_counter
*
* @attr: attributes of the counter to create
8<-----------------
Cheers!
Pawel
next prev parent reply other threads:[~2013-02-06 18:17 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 10:13 [RFC] perf: need to expose sched_clock to correlate user samples with kernel samples Stephane Eranian
2012-10-16 17:23 ` Peter Zijlstra
2012-10-18 19:33 ` Stephane Eranian
2012-11-10 2:04 ` John Stultz
2012-11-11 20:32 ` Stephane Eranian
2012-11-12 18:53 ` John Stultz
2012-11-12 20:54 ` Stephane Eranian
2012-11-12 22:39 ` John Stultz
2012-11-13 20:58 ` Steven Rostedt
2012-11-14 22:26 ` John Stultz
2012-11-14 23:30 ` Steven Rostedt
2013-02-01 14:18 ` Pawel Moll
2013-02-05 21:18 ` David Ahern
2013-02-05 22:13 ` Stephane Eranian
2013-02-05 22:28 ` John Stultz
2013-02-06 1:19 ` Steven Rostedt
2013-02-06 18:17 ` Pawel Moll [this message]
2013-02-13 20:00 ` Stephane Eranian
2013-02-14 10:33 ` Pawel Moll
2013-02-18 15:16 ` Stephane Eranian
2013-02-18 18:59 ` David Ahern
2013-02-18 20:35 ` Thomas Gleixner
2013-02-19 18:25 ` John Stultz
2013-02-19 19:55 ` Thomas Gleixner
2013-02-19 20:15 ` Thomas Gleixner
2013-02-19 20:35 ` John Stultz
2013-02-19 21:50 ` Thomas Gleixner
2013-02-19 22:20 ` John Stultz
2013-02-20 10:06 ` Thomas Gleixner
2013-02-20 10:29 ` Peter Zijlstra
2013-02-23 6:04 ` John Stultz
2013-02-25 14:10 ` Peter Zijlstra
2013-03-14 15:34 ` Stephane Eranian
2013-03-14 19:57 ` Pawel Moll
2013-03-31 16:23 ` David Ahern
2013-04-01 18:29 ` John Stultz
2013-04-01 22:29 ` David Ahern
2013-04-01 23:12 ` John Stultz
2013-04-03 9:17 ` Stephane Eranian
2013-04-03 13:55 ` David Ahern
2013-04-03 14:00 ` Stephane Eranian
2013-04-03 14:14 ` David Ahern
2013-04-03 14:22 ` Stephane Eranian
2013-04-03 17:57 ` John Stultz
2013-04-04 8:12 ` Stephane Eranian
2013-04-04 22:26 ` John Stultz
2013-04-02 7:54 ` Peter Zijlstra
2013-04-02 16:05 ` Pawel Moll
2013-04-02 16:19 ` John Stultz
2013-04-02 16:34 ` Pawel Moll
2013-04-03 17:19 ` Pawel Moll
2013-04-03 17:29 ` John Stultz
2013-04-03 17:35 ` Pawel Moll
2013-04-03 17:50 ` John Stultz
2013-04-04 7:37 ` Richard Cochran
2013-04-04 16:33 ` Pawel Moll
2013-04-04 16:29 ` Pawel Moll
2013-04-05 18:16 ` Pawel Moll
2013-04-06 11:05 ` Richard Cochran
2013-04-08 17:58 ` Pawel Moll
2013-04-08 19:05 ` John Stultz
2013-04-09 5:02 ` Richard Cochran
2013-02-06 18:17 ` Pawel Moll
2013-06-26 16:49 ` David Ahern
2013-07-15 10:44 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360174657.4045.33.camel@hornet \
--to=pawel.moll@arm.com \
--cc=Will.Deacon@arm.com \
--cc=ak@linux.intel.com \
--cc=anton@samba.org \
--cc=eranian@google.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=penberg@gmail.com \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox