Re: [PATCH v2 7/7] spi: spi-fsl-spi: Add support for gpio chipselects for GRLIB type cores

Grant Likely
2013-03-03T12:07:59Z

On Thu, 7 Feb 2013 08:08:21 -0800, Anton Vorontsov <anton@enomsg.org> wrote:
> On Thu, Feb 07, 2013 at 02:12:11PM +0100, Andreas Larsson wrote:
> > This relies upon of_spi_register_master to find out which gpios to use.
> >
> > Signed-off-by: Andreas Larsson <andreas@gaisler.com>
> > ---
> > drivers/spi/spi-fsl-lib.h | 1 +
> > drivers/spi/spi-fsl-spi.c | 53 +++++++++++++++++++++++++++++++++++++++-----
> > 2 files changed, 48 insertions(+), 6 deletions(-)
>
> Just a couple of minor nits...
>
> > diff --git a/drivers/spi/spi-fsl-lib.h b/drivers/spi/spi-fsl-lib.h
> > index d5c788b..52db693 100644
> > --- a/drivers/spi/spi-fsl-lib.h
> > +++ b/drivers/spi/spi-fsl-lib.h
> > @@ -71,6 +71,7 @@ struct mpc8xxx_spi {
> >
> > #ifdef CONFIG_SPI_FSL_SPI
> > int type;
> > + int native_chipselects;
> > u8 max_bits_per_word;
> >
> > void (*set_shifts)(u32 *rx_shift, u32 *tx_shift,
> > diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c
> > index 55652e6..2befe16 100644
> > --- a/drivers/spi/spi-fsl-spi.c
> > +++ b/drivers/spi/spi-fsl-spi.c
> > @@ -418,7 +418,7 @@ static int fsl_spi_setup(struct spi_device *spi)
> > {
> > struct mpc8xxx_spi *mpc8xxx_spi;
> > struct fsl_spi_reg *reg_base;
> > - int retval;
> > + int retval, desel;
>
> We don't usually place variable declarations on the same line, unless the
> variables are closely related.

That's not something I've ever heard before. I certainly won't reject a
patch over it.

g.