Re: [PATCH v2 02/26] x86, irq: Modify irq chip once for irq remapping

Thomas Gleixner
2013-03-08T20:07:59Z

On Fri, 8 Feb 2013, Yinghai Lu wrote:

> Now after irq remapping is enabled, irq_chip fields are modified during
> every irq setup.
>
> Only need to change them one during we enable irq mapping.

Can you please start to write sensible changelogs? I'm really sick of
your sloppyness.

> Also change irq_remap_modify_chip_defaults() to __init.

Why can you do that ?

> We don't need to use #ifdef in irq_remap_modify_chips(), as
> IRQ_REMAP only support x86_64 AND X86_IO_APIC AND PCI_MSI,
> also HPET_TIMER is set when x86_64 is set.

You should not describe what the patch is doing, you are again missing
to describe why the patch is doing this.

Sigh.

tglx