From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761020Ab3BJDff (ORCPT ); Sat, 9 Feb 2013 22:35:35 -0500 Received: from mailout01.c08.mtsvc.net ([205.186.168.189]:53623 "EHLO mailout01.c08.mtsvc.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760972Ab3BJDfc (ORCPT ); Sat, 9 Feb 2013 22:35:32 -0500 X-Greylist: delayed 1234 seconds by postgrey-1.27 at vger.kernel.org; Sat, 09 Feb 2013 22:35:32 EST Message-ID: <1360466060.3703.15.camel@thor.lan> Subject: [Bisected] [-next-20130204] usb/hcd: irq 18: nobody cared From: Peter Hurley To: Yinghai Lu , Bjorn Helgaas , "Rafael J. Wysocki" Cc: Alan Stern , Lan Tianyu , Greg Kroah-Hartman , Jiri Kosina , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Date: Sat, 09 Feb 2013 22:14:20 -0500 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.3-0pjh1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Authenticated-User: 125194 peter@hurleysoftware.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-02-05 at 15:26 -0500, Alan Stern wrote: > On Tue, 5 Feb 2013, Peter Hurley wrote: > > > With -next-20130204: > > > > [ 33.855570] irq 18: nobody cared (try booting with the "irqpoll" option) > > [ 33.855580] Pid: 0, comm: swapper/4 Not tainted 3.8.0-next-20130204-xeon #20130204 > > [ 33.855582] Call Trace: > > [ 33.855585] [] __report_bad_irq+0x36/0xe0 > > [ 33.855600] [] note_interrupt+0x1aa/0x200 > > [ 33.855606] [] ? mwait_idle+0x82/0x1b0 > > [ 33.855610] [] handle_irq_event_percpu+0xc9/0x260 > > [ 33.855614] [] handle_irq_event+0x48/0x70 > > [ 33.855618] [] handle_fasteoi_irq+0x5a/0x100 > > [ 33.855624] [] handle_irq+0x22/0x40 > > [ 33.855630] [] do_IRQ+0x5a/0xd0 > > [ 33.855636] [] common_interrupt+0x6d/0x6d > > [ 33.855638] [] ? rcu_eqs_enter_common+0x4a/0x320 > > [ 33.855646] [] ? mwait_idle+0x82/0x1b0 > > [ 33.855649] [] ? mwait_idle+0x29/0x1b0 > > [ 33.855653] [] cpu_idle+0x116/0x130 > > [ 33.855658] [] start_secondary+0x251/0x258 > > [ 33.855660] handlers: > > [ 33.855664] [] usb_hcd_irq > > [ 33.855667] Disabling IRQ #18 > > > > From earlier in the boot log: > > [ 1.297020] uhci_hcd 0000:00:1d.2: setting latency timer to 64 > > [ 1.297032] uhci_hcd 0000:00:1d.2: UHCI Host Controller > > [ 1.297040] uhci_hcd 0000:00:1d.2: new USB bus registered, assigned bus number 4 > > [ 1.297076] uhci_hcd 0000:00:1d.2: irq 18, io base 0x0000ff40 > > [ 1.297213] hub 4-0:1.0: USB hub found > > [ 1.297221] hub 4-0:1.0: 2 ports detected > > > > lsusb: > > ... > > Bus 004 Device 002: ID 0764:0501 Cyber Power System, Inc. CP1500 AVR UPS > > Bus 004 Device 003: ID 046d:c52b Logitech, Inc. Unifying Receiver [...] > If the suggestion above doesn't work out, bisection may be the best way > to find the answer. This bad irq bisected to: 4f535093cf8f6da8cfda7c36c2c1ecd2e9586ee4 is the first bad commit commit 4f535093cf8f6da8cfda7c36c2c1ecd2e9586ee4 Author: Yinghai Lu Date: Mon Jan 21 13:20:52 2013 -0800 PCI: Put pci_dev in device tree as early as possible We want to put pci_dev structs in the device tree as soon as possible so for_each_pci_dev() iteration will not miss them, but driver attachment needs to be delayed until after pci_assign_unassigned_resources() to make sure all devices have resources assigned first. This patch moves device registering from pci_bus_add_devices() to pci_device_add(), which happens earlier, leaving driver attachment in pci_bus_add_devices(). It also removes unattached child bus handling in pci_bus_add_devices(). That's not needed because child bus via pci_add_new_bus() is already in parent bus children list. [bhelgaas: changelog] Signed-off-by: Yinghai Lu Signed-off-by: Bjorn Helgaas Acked-by: Rafael J. Wysocki :040000 040000 0540c98d04d00de24b4e12fa750f6cd26c5addd2 2e24946cb7165a4028b7efb0a622271cc3990005 M drivers All is fine if I revert these 2 commits: 40064ac PCI: Remove unused "rc" in virtfn_add_bus() 4f53509 (HEAD, refs/bisect/bad) PCI: Put pci_dev in device tree as early as possible Any ideas how these are causing the USB HCD core / hid-logitech-dj driver to drop interrupts? Regards, Peter Hurley