From: Alexandre Courbot <gnurou@gmail.com>
To: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org, gnurou@gmail.com,
Alexandre Courbot <acourbot@nvidia.com>
Subject: [PATCH 4/4] gpiolib: rename local offset variables to "hwgpio"
Date: Wed, 13 Feb 2013 16:03:02 +0900 [thread overview]
Message-ID: <1360738983-22436-5-git-send-email-gnurou@gmail.com> (raw)
In-Reply-To: <1360738983-22436-1-git-send-email-gnurou@gmail.com>
From: Alexandre Courbot <acourbot@nvidia.com>
Their value being obtained by gpio_chip_hwgpio(), this better reflects
their use.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
drivers/gpio/gpiolib.c | 70 +++++++++++++++++++++++++-------------------------
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index d8aa1a0..42838c2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -72,7 +72,7 @@ struct gpio_desc {
};
static struct gpio_desc gpio_desc[ARCH_NR_GPIOS];
-#define GPIO_OFFSET_VALID(chip, offset) (offset >= 0 && offset < chip->ngpio)
+#define GPIO_HWNUM_VALID(chip, hwgpio) (hwgpio >= 0 && hwgpio < chip->ngpio)
static LIST_HEAD(gpio_chips);
@@ -211,16 +211,16 @@ static int gpiochip_find_base(int ngpio)
static int gpiod_get_direction(const struct gpio_desc *desc)
{
struct gpio_chip *chip;
- unsigned offset;
+ unsigned hwgpio;
int status = -EINVAL;
chip = gpiod_to_chip(desc);
- offset = gpio_chip_hwgpio(desc);
+ hwgpio = gpio_chip_hwgpio(desc);
if (!chip->get_direction)
return status;
- status = chip->get_direction(chip, offset);
+ status = chip->get_direction(chip, hwgpio);
if (status > 0) {
/* GPIOF_DIR_IN, or other positive */
status = 1;
@@ -754,7 +754,7 @@ static int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
int status;
const char *ioname = NULL;
struct device *dev;
- int offset;
+ int hwgpio;
/* can't export until sysfs is available ... */
if (!gpio_class.p) {
@@ -785,9 +785,9 @@ static int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
direction_may_change = false;
spin_unlock_irqrestore(&gpio_lock, flags);
- offset = gpio_chip_hwgpio(desc);
- if (desc->chip->names && desc->chip->names[offset])
- ioname = desc->chip->names[offset];
+ hwgpio = gpio_chip_hwgpio(desc);
+ if (desc->chip->names && desc->chip->names[hwgpio])
+ ioname = desc->chip->names[hwgpio];
dev = device_create(&gpio_class, desc->chip->dev, MKDEV(0, 0),
desc, ioname ? ioname : "gpio%u",
@@ -1591,7 +1591,7 @@ const char *gpiochip_is_requested(struct gpio_chip *chip, unsigned offset)
{
struct gpio_desc *desc;
- if (!GPIO_OFFSET_VALID(chip, offset))
+ if (!GPIO_HWNUM_VALID(chip, offset))
return NULL;
desc = &chip->desc[offset];
@@ -1621,7 +1621,7 @@ static int gpiod_direction_input(struct gpio_desc *desc)
unsigned long flags;
struct gpio_chip *chip;
int status = -EINVAL;
- int offset;
+ int hwgpio;
spin_lock_irqsave(&gpio_lock, flags);
@@ -1640,9 +1640,9 @@ static int gpiod_direction_input(struct gpio_desc *desc)
might_sleep_if(chip->can_sleep);
- offset = gpio_chip_hwgpio(desc);
+ hwgpio = gpio_chip_hwgpio(desc);
if (status) {
- status = chip->request(chip, offset);
+ status = chip->request(chip, hwgpio);
if (status < 0) {
pr_debug("GPIO-%d: chip request fail, %d\n",
desc_to_gpio(desc), status);
@@ -1653,7 +1653,7 @@ static int gpiod_direction_input(struct gpio_desc *desc)
}
}
- status = chip->direction_input(chip, offset);
+ status = chip->direction_input(chip, hwgpio);
if (status == 0)
clear_bit(FLAG_IS_OUT, &desc->flags);
@@ -1679,7 +1679,7 @@ static int gpiod_direction_output(struct gpio_desc *desc, int value)
unsigned long flags;
struct gpio_chip *chip;
int status = -EINVAL;
- int offset;
+ int hwgpio;
if (!desc)
goto fail_unlocked;
@@ -1707,9 +1707,9 @@ static int gpiod_direction_output(struct gpio_desc *desc, int value)
might_sleep_if(chip->can_sleep);
- offset = gpio_chip_hwgpio(desc);
+ hwgpio = gpio_chip_hwgpio(desc);
if (status) {
- status = chip->request(chip, offset);
+ status = chip->request(chip, hwgpio);
if (status < 0) {
pr_debug("GPIO-%d: chip request fail, %d\n",
desc_to_gpio(desc), status);
@@ -1720,7 +1720,7 @@ static int gpiod_direction_output(struct gpio_desc *desc, int value)
}
}
- status = chip->direction_output(chip, offset, value);
+ status = chip->direction_output(chip, hwgpio, value);
if (status == 0)
set_bit(FLAG_IS_OUT, &desc->flags);
trace_gpio_value(desc_to_gpio(desc), 0, value);
@@ -1752,7 +1752,7 @@ static int gpiod_set_debounce(struct gpio_desc *desc, unsigned debounce)
unsigned long flags;
struct gpio_chip *chip;
int status = -EINVAL;
- int offset;
+ int hwgpio;
spin_lock_irqsave(&gpio_lock, flags);
@@ -1772,8 +1772,8 @@ static int gpiod_set_debounce(struct gpio_desc *desc, unsigned debounce)
might_sleep_if(chip->can_sleep);
- offset = gpio_chip_hwgpio(desc);
- return chip->set_debounce(chip, offset, debounce);
+ hwgpio = gpio_chip_hwgpio(desc);
+ return chip->set_debounce(chip, hwgpio, debounce);
fail:
spin_unlock_irqrestore(&gpio_lock, flags);
@@ -1825,15 +1825,15 @@ static int gpiod_get_value(const struct gpio_desc *desc)
{
struct gpio_chip *chip;
int value;
- int offset;
+ int hwgpio;
if (!desc)
return 0;
chip = desc->chip;
- offset = gpio_chip_hwgpio(desc);
+ hwgpio = gpio_chip_hwgpio(desc);
/* Should be using gpio_get_value_cansleep() */
WARN_ON(chip->can_sleep);
- value = chip->get ? chip->get(chip, offset) : 0;
+ value = chip->get ? chip->get(chip, hwgpio) : 0;
trace_gpio_value(desc_to_gpio(desc), 1, value);
return value;
}
@@ -1854,14 +1854,14 @@ static void _gpio_set_open_drain_value(struct gpio_desc *desc, int value)
{
int err = 0;
struct gpio_chip *chip = desc->chip;
- int offset = gpio_chip_hwgpio(desc);
+ int hwgpio = gpio_chip_hwgpio(desc);
if (value) {
- err = chip->direction_input(chip, offset);
+ err = chip->direction_input(chip, hwgpio);
if (!err)
clear_bit(FLAG_IS_OUT, &desc->flags);
} else {
- err = chip->direction_output(chip, offset, 0);
+ err = chip->direction_output(chip, hwgpio, 0);
if (!err)
set_bit(FLAG_IS_OUT, &desc->flags);
}
@@ -1881,14 +1881,14 @@ static void _gpio_set_open_source_value(struct gpio_desc *desc, int value)
{
int err = 0;
struct gpio_chip *chip = desc->chip;
- int offset = gpio_chip_hwgpio(desc);
+ int hwgpio = gpio_chip_hwgpio(desc);
if (value) {
- err = chip->direction_output(chip, offset, 1);
+ err = chip->direction_output(chip, hwgpio, 1);
if (!err)
set_bit(FLAG_IS_OUT, &desc->flags);
} else {
- err = chip->direction_input(chip, offset);
+ err = chip->direction_input(chip, hwgpio);
if (!err)
clear_bit(FLAG_IS_OUT, &desc->flags);
}
@@ -1965,13 +1965,13 @@ EXPORT_SYMBOL_GPL(__gpio_cansleep);
static int gpiod_to_irq(const struct gpio_desc *desc)
{
struct gpio_chip *chip;
- int offset;
+ int hwgpio;
if (!desc)
return -EINVAL;
chip = desc->chip;
- offset = gpio_chip_hwgpio(desc);
- return chip->to_irq ? chip->to_irq(chip, offset) : -ENXIO;
+ hwgpio = gpio_chip_hwgpio(desc);
+ return chip->to_irq ? chip->to_irq(chip, hwgpio) : -ENXIO;
}
int __gpio_to_irq(unsigned gpio)
@@ -1989,14 +1989,14 @@ static int gpiod_get_value_cansleep(const struct gpio_desc *desc)
{
struct gpio_chip *chip;
int value;
- int offset;
+ int hwgpio;
might_sleep_if(extra_checks);
if (!desc)
return 0;
chip = desc->chip;
- offset = gpio_chip_hwgpio(desc);
- value = chip->get ? chip->get(chip, offset) : 0;
+ hwgpio = gpio_chip_hwgpio(desc);
+ value = chip->get ? chip->get(chip, hwgpio) : 0;
trace_gpio_value(desc_to_gpio(desc), 1, value);
return value;
}
--
1.8.1.3
next prev parent reply other threads:[~2013-02-13 7:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 7:02 [PATCH 0/4] gpiolib: some fixup patches Alexandre Courbot
2013-02-13 7:02 ` [PATCH 1/4] gpiolib: check descriptors validity before use Alexandre Courbot
2013-02-13 22:49 ` Ryan Mallon
2013-02-14 3:00 ` Alexandre Courbot
2013-02-13 7:03 ` [PATCH 2/4] gpiolib: use const parameters when possible Alexandre Courbot
2014-11-17 9:09 ` Uwe Kleine-König
2014-11-19 8:33 ` Alexandre Courbot
2014-11-19 8:44 ` Uwe Kleine-König
2014-11-19 8:57 ` Alexandre Courbot
2014-11-19 9:02 ` Uwe Kleine-König
2014-11-19 9:07 ` Alexandre Courbot
2014-11-19 10:09 ` Uwe Kleine-König
2014-11-25 7:37 ` Alexandre Courbot
2014-11-25 9:36 ` Janusz Użycki
2013-02-13 7:03 ` [PATCH 3/4] gpiolib: move comment to right function Alexandre Courbot
2013-02-13 7:03 ` Alexandre Courbot [this message]
2013-02-13 22:54 ` [PATCH 4/4] gpiolib: rename local offset variables to "hwgpio" Ryan Mallon
2013-02-14 3:11 ` Alexandre Courbot
2013-02-13 7:03 ` Alexandre Courbot
-- strict thread matches above, loose matches on Subject: below --
2013-02-15 5:46 [PATCH v2 0/4] gpiolib: some fixup patches Alexandre Courbot
2013-02-15 5:46 ` [PATCH 4/4] gpiolib: rename local offset variables to "hwgpio" Alexandre Courbot
2013-02-26 17:51 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360738983-22436-5-git-send-email-gnurou@gmail.com \
--to=gnurou@gmail.com \
--cc=acourbot@nvidia.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).