linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Pawel Moll <pawel.moll@arm.com>
Subject: [PATCH] virtio-spec: Define virtio-mmio registers as LE
Date: Thu, 14 Feb 2013 10:54:06 +0000	[thread overview]
Message-ID: <1360839247-9131-1-git-send-email-pawel.moll@arm.com> (raw)
In-Reply-To: <87wqubkalj.fsf@rustcorp.com.au>

To solve the never-ending confusions between hosts and guests
of different endianess, define all virtio-mmio registers as LE.

This change should be safe at this stage, because no known
working mixed-endian system exists so there is virtually no
risk of breaking compatibility.

Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
 virtio-spec.lyx |   30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index 1ba9992..a00b675 100644
--- a/virtio-spec.lyx
+++ b/virtio-spec.lyx
@@ -56,6 +56,7 @@
 \html_math_output 0
 \html_css_as_file 0
 \html_be_strict false
+\author -875410574 "Pawel Moll" 
 \author -608949062 "Rusty Russell,,," 
 \author -385801441 "Cornelia Huck" cornelia.huck@de.ibm.com
 \author 1112500848 "Rusty Russell" rusty@rustcorp.com.au
@@ -1850,6 +1851,17 @@ struct vring {
 
 \begin_layout Subsection
 A Note on Virtqueue Endianness
+\change_inserted -875410574 1360838374
+
+\begin_inset CommandInset label
+LatexCommand label
+name "sub:Virtqueue-Endianness"
+
+\end_inset
+
+
+\change_unchanged
+
 \end_layout
 
 \begin_layout Standard
@@ -9850,8 +9862,24 @@ a
 \end_layout
 
 \begin_layout Standard
+
+\change_deleted -875410574 1360838214
 The endianness of the registers follows the native endianness of the Guest.
- Writing to registers described as 
+\change_inserted -875410574 1360838930
+All register values are organized as Little Endian, similarly to the PCI
+ variant, see also 
+\begin_inset CommandInset ref
+LatexCommand ref
+reference "sub:Virtqueue-Endianness"
+
+\end_inset
+
+.
+ 
+\change_deleted -875410574 1360838262
+ 
+\change_unchanged
+Writing to registers described as 
 \begin_inset Quotes eld
 \end_inset
 
-- 
1.7.10.4



  reply	other threads:[~2013-02-14 10:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 14:25 [RFC PATCH] virt_mmio: fix signature checking for BE guests Marc Zyngier
2013-02-13 15:08 ` Pawel Moll
2013-02-13 15:28   ` Marc Zyngier
2013-02-13 15:46     ` Pawel Moll
2013-02-13 16:40       ` Marc Zyngier
2013-02-13 16:53     ` Michael S. Tsirkin
2013-02-13 17:04       ` Marc Zyngier
2013-02-14  0:22       ` Rusty Russell
2013-02-14 10:54         ` Pawel Moll [this message]
2013-02-15  3:57           ` [PATCH] virtio-spec: Define virtio-mmio registers as LE Rusty Russell
2013-03-01 10:41           ` Marc Zyngier
2013-03-01 10:50             ` Pawel Moll
2013-03-01 11:21               ` Marc Zyngier
2013-03-01 12:37                 ` Pawel Moll
2013-03-01 13:16                   ` Marc Zyngier
2013-03-05  0:11                   ` Rusty Russell
2013-03-06 15:10                     ` Pawel Moll
2013-03-07  6:36                       ` Rusty Russell
2013-02-15  0:07     ` [RFC PATCH] virt_mmio: fix signature checking for BE guests Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360839247-9131-1-git-send-email-pawel.moll@arm.com \
    --to=pawel.moll@arm.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).