From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <john.stultz@linaro.org>,
x86@kernel.org, Matt Fleming <matt.fleming@intel.com>,
David Vrabel <david.vrabel@citrix.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>,
linux-efi@vger.kernel.org
Subject: [RFE PATCH 2/2] rtc, add write functionality to sysfs
Date: Thu, 14 Feb 2013 12:02:55 -0500 [thread overview]
Message-ID: <1360861375-24131-3-git-send-email-prarit@redhat.com> (raw)
In-Reply-To: <1360861375-24131-1-git-send-email-prarit@redhat.com>
/sys/class/rtc/rtcX/date and /sys/class/rtc/rtcX/time currently have
read-only access. This patch introduces write functionality which will
set the rtc time.
Usage: echo YYYY-MM-DD > /sys/class/rtc/rtcX/date
echo HH:MM:SS > /sys/class/rtc/rtcX/time
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: John Stultz <john.stultz@linaro.org>
Cc: x86@kernel.org
Cc: Matt Fleming <matt.fleming@intel.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: linux-efi@vger.kernel.org
---
drivers/rtc/rtc-sysfs.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 84 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c
index b70e2bb..87d63d7 100644
--- a/drivers/rtc/rtc-sysfs.c
+++ b/drivers/rtc/rtc-sysfs.c
@@ -48,6 +48,46 @@ rtc_sysfs_show_date(struct device *dev, struct device_attribute *attr,
}
static ssize_t
+rtc_sysfs_store_date(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ ssize_t retval;
+ struct rtc_time tm;
+ char tmp[11] = "\0", *tmpptr = tmp;
+ char *cyear, *cmonth, *cday;
+ int year, month, day;
+
+ if (!capable(CAP_SYS_TIME))
+ return -EPERM;
+
+ /* from rtc_sysfs_show_date(): date string format is YYYY-MM-DD */
+ if (strlen(buf) != 11)
+ return -EINVAL;
+
+ strncpy(tmp, buf, 11);
+ cyear = strsep(&tmpptr, "-");
+ sscanf(cyear, "%i", &year);
+ cmonth = strsep(&tmpptr, "-");
+ sscanf(cmonth, "%i", &month);
+ cday = strsep(&tmpptr, "-");
+ sscanf(cday, "%i", &day);
+
+ retval = rtc_read_time(to_rtc_device(dev), &tm);
+ if (retval)
+ return -ENODEV;
+
+ tm.tm_year = year - 1900;
+ tm.tm_mon = month - 1;
+ tm.tm_mday = day;
+
+ retval = rtc_set_time(to_rtc_device(dev), &tm);
+ if (retval)
+ return retval;
+
+ return count;
+}
+
+static ssize_t
rtc_sysfs_show_time(struct device *dev, struct device_attribute *attr,
char *buf)
{
@@ -64,6 +104,46 @@ rtc_sysfs_show_time(struct device *dev, struct device_attribute *attr,
}
static ssize_t
+rtc_sysfs_store_time(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ ssize_t retval;
+ struct rtc_time tm;
+ char tmp[9] = "\0", *tmpptr = tmp;
+ char *chour, *cmin, *csec;
+ int hour, min, sec;
+
+ if (!capable(CAP_SYS_TIME))
+ return -EPERM;
+
+ /* from rtc_sysfs_show_time(): time string format is HH:MM:SS */
+ if (strlen(buf) != 9)
+ return -EINVAL;
+
+ strncpy(tmp, buf, 9);
+ chour = strsep(&tmpptr, ":");
+ sscanf(chour, "%i", &hour);
+ cmin = strsep(&tmpptr, ":");
+ sscanf(cmin, "%i", &min);
+ csec = strsep(&tmpptr, ":");
+ sscanf(csec, "%i", &sec);
+
+ retval = rtc_read_time(to_rtc_device(dev), &tm);
+ if (retval)
+ return -ENODEV;
+
+ tm.tm_hour = hour;
+ tm.tm_min = min;
+ tm.tm_sec = sec;
+
+ retval = rtc_set_time(to_rtc_device(dev), &tm);
+ if (retval)
+ return retval;
+
+ return count;
+}
+
+static ssize_t
rtc_sysfs_show_since_epoch(struct device *dev, struct device_attribute *attr,
char *buf)
{
@@ -124,8 +204,10 @@ rtc_sysfs_show_hctosys(struct device *dev, struct device_attribute *attr,
static struct device_attribute rtc_attrs[] = {
__ATTR(name, S_IRUGO, rtc_sysfs_show_name, NULL),
- __ATTR(date, S_IRUGO, rtc_sysfs_show_date, NULL),
- __ATTR(time, S_IRUGO, rtc_sysfs_show_time, NULL),
+ __ATTR(date, S_IRUGO | S_IWUGO, rtc_sysfs_show_date,
+ rtc_sysfs_store_date),
+ __ATTR(time, S_IRUGO | S_IWUGO, rtc_sysfs_show_time,
+ rtc_sysfs_store_time),
__ATTR(since_epoch, S_IRUGO, rtc_sysfs_show_since_epoch, NULL),
__ATTR(max_user_freq, S_IRUGO | S_IWUSR, rtc_sysfs_show_max_user_freq,
rtc_sysfs_set_max_user_freq),
--
1.8.1.2
next prev parent reply other threads:[~2013-02-14 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 17:02 [RFE PATCH 0/2] x86, rtc, ntp, Enable full rtc synchronization Prarit Bhargava
2013-02-14 17:02 ` [RFE PATCH 1/2] x86, rtc, ntp, Do full rtc synchronization with ntp Prarit Bhargava
2013-02-22 20:42 ` John Stultz
2013-02-24 17:12 ` Prarit Bhargava
2013-02-25 15:04 ` Alessandro Zummo
2013-02-14 17:02 ` Prarit Bhargava [this message]
2013-02-22 20:43 ` [RFE PATCH 2/2] rtc, add write functionality to sysfs John Stultz
2013-02-22 20:55 ` Prarit Bhargava
2013-02-22 21:05 ` John Stultz
2013-02-23 23:11 ` Alessandro Zummo
2013-02-24 17:03 ` Prarit Bhargava
2013-02-25 14:58 ` Alessandro Zummo
2013-02-28 14:50 ` Prarit Bhargava
2013-02-28 18:51 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360861375-24131-3-git-send-email-prarit@redhat.com \
--to=prarit@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=david.vrabel@citrix.com \
--cc=john.stultz@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).