linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Daniel Baluta <dbaluta@ixiacom.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 10/10] perf/hwbp: Fix cleanup in case of kzalloc failure
Date: Thu, 14 Feb 2013 18:44:23 -0300	[thread overview]
Message-ID: <1360878263-12694-11-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1360878263-12694-1-git-send-email-acme@infradead.org>

From: Daniel Baluta <dbaluta@ixiacom.com>

Obviously this is a typo and could result in memory leaks if kzalloc
fails on a given cpu.

Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1360186160-7566-1-git-send-email-dbaluta@ixiacom.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 kernel/events/hw_breakpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index fe8a916..a64f8ae 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -676,7 +676,7 @@ int __init init_hw_breakpoint(void)
  err_alloc:
 	for_each_possible_cpu(err_cpu) {
 		for (i = 0; i < TYPE_MAX; i++)
-			kfree(per_cpu(nr_task_bp_pinned[i], cpu));
+			kfree(per_cpu(nr_task_bp_pinned[i], err_cpu));
 		if (err_cpu == cpu)
 			break;
 	}
-- 
1.8.1.1.361.gec3ae6e


  parent reply	other threads:[~2013-02-14 21:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 21:44 [GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 01/10] perf buildid-cache: Add --update option Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 02/10] perf annotate: Fix warning message on a missing vmlinux Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 03/10] perf ui/gtk: Implement basic GTK2 annotation browser Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 04/10] perf gtk/annotate: Support multiple event annotation Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 05/10] perf gtk/annotate: Show source lines with gray color Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 06/10] perf gtk/annotate: Fail early if it can't annotate Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 07/10] perf annotate: Make it to be able to skip unannotatable symbols Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 08/10] perf tools: Limit unwind support to x86 archs Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 09/10] perf tools: Fix build with bison 2.3 and older Arnaldo Carvalho de Melo
2013-02-14 21:44 ` Arnaldo Carvalho de Melo [this message]
2013-02-15 15:39 ` [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360878263-12694-11-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dbaluta@ixiacom.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).