From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <andi@firstfloor.org>, Borislav Petkov <bp@alien8.de>,
Jiri Olsa <jolsa@redhat.com>, Paul Mackerras <paulus@samba.org>,
Pekka Enberg <penberg@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 05/10] perf gtk/annotate: Show source lines with gray color
Date: Thu, 14 Feb 2013 18:44:18 -0300 [thread overview]
Message-ID: <1360878263-12694-6-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1360878263-12694-1-git-send-email-acme@infradead.org>
From: Namhyung Kim <namhyung.kim@lge.com>
In order to differentiate source lines from asm line, print them with
gray color. To do this, it needs to be escaped since sometimes it
contains "<" and/or ">" characters so that it should not be considered
as a markup tags. Use glib's g_markup_escape_text() for this.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1360227734-375-4-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/gtk/annotate.c | 30 +++++++++++++++++++++++++++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/tools/perf/ui/gtk/annotate.c b/tools/perf/ui/gtk/annotate.c
index 1ce89f2..2fe056b 100644
--- a/tools/perf/ui/gtk/annotate.c
+++ b/tools/perf/ui/gtk/annotate.c
@@ -60,6 +60,30 @@ static int perf_gtk__get_offset(char *buf, size_t size, struct symbol *sym,
return scnprintf(buf, size, "%"PRIx64, start + dl->offset);
}
+static int perf_gtk__get_line(char *buf, size_t size, struct disasm_line *dl)
+{
+ int ret = 0;
+ char *line = g_markup_escape_text(dl->line, -1);
+ const char *markup = "<span fgcolor='gray'>";
+
+ strcpy(buf, "");
+
+ if (!line)
+ return 0;
+
+ if (dl->offset != (s64) -1)
+ markup = NULL;
+
+ if (markup)
+ ret += scnprintf(buf, size, "%s", markup);
+ ret += scnprintf(buf + ret, size - ret, "%s", line);
+ if (markup)
+ ret += scnprintf(buf + ret, size - ret, "</span>");
+
+ g_free(line);
+ return ret;
+}
+
static int perf_gtk__annotate_symbol(GtkWidget *window, struct symbol *sym,
struct map *map, int evidx,
struct hist_browser_timer *hbt __maybe_unused)
@@ -93,8 +117,7 @@ static int perf_gtk__annotate_symbol(GtkWidget *window, struct symbol *sym,
for (i = 0; i < MAX_ANN_COLS; i++) {
gtk_tree_view_insert_column_with_attributes(GTK_TREE_VIEW(view),
- -1, col_names[i], renderer,
- i == ANN_COL__PERCENT ? "markup" : "text",
+ -1, col_names[i], renderer, "markup",
i, NULL);
}
@@ -110,7 +133,8 @@ static int perf_gtk__annotate_symbol(GtkWidget *window, struct symbol *sym,
gtk_list_store_set(store, &iter, ANN_COL__PERCENT, s, -1);
if (perf_gtk__get_offset(s, sizeof(s), sym, map, pos))
gtk_list_store_set(store, &iter, ANN_COL__OFFSET, s, -1);
- gtk_list_store_set(store, &iter, ANN_COL__LINE, pos->line, -1);
+ if (perf_gtk__get_line(s, sizeof(s), pos))
+ gtk_list_store_set(store, &iter, ANN_COL__LINE, s, -1);
}
gtk_container_add(GTK_CONTAINER(window), view);
--
1.8.1.1.361.gec3ae6e
next prev parent reply other threads:[~2013-02-14 21:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 21:44 [GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 01/10] perf buildid-cache: Add --update option Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 02/10] perf annotate: Fix warning message on a missing vmlinux Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 03/10] perf ui/gtk: Implement basic GTK2 annotation browser Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 04/10] perf gtk/annotate: Support multiple event annotation Arnaldo Carvalho de Melo
2013-02-14 21:44 ` Arnaldo Carvalho de Melo [this message]
2013-02-14 21:44 ` [PATCH 06/10] perf gtk/annotate: Fail early if it can't annotate Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 07/10] perf annotate: Make it to be able to skip unannotatable symbols Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 08/10] perf tools: Limit unwind support to x86 archs Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 09/10] perf tools: Fix build with bison 2.3 and older Arnaldo Carvalho de Melo
2013-02-14 21:44 ` [PATCH 10/10] perf/hwbp: Fix cleanup in case of kzalloc failure Arnaldo Carvalho de Melo
2013-02-15 15:39 ` [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360878263-12694-6-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).