public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Berger <git.rber@gmail.com>
To: devel@driverdev.osuosl.org, konrad.wilk@oracle.com
Cc: gregkh@linuxfoundation.org, sjenning@linux.vnet.ibm.com,
	xiaoguangrong@linux.vnet.ibm.com, minchan@kernel.org,
	linux-kernel@vger.kernel.org, rber.git@gmail.com,
	Robert Berger <rber.git@ReliableEmbeddedSystems.com>
Subject: [PATCH] staging/zcache fixed some checkpatch issues
Date: Fri, 15 Feb 2013 12:53:00 +0200	[thread overview]
Message-ID: <1360925580-18633-1-git-send-email-rber.git@ReliableEmbeddedSystems.com> (raw)
In-Reply-To: <staging/zcache fixed some checkpatch issues>

tmem.c:76: ERROR: "foo*bar" should be "foo *bar"
zcache-main.c:2057: WARNING: quoted string split across lines
zcache-main.c:2059: WARNING: Prefer pr_warn(... to pr_warning(...
zcache-main.c:2068: WARNING: quoted string split across lines
zcache-main.c:2070: WARNING: Prefer pr_warn(... to pr_warning(...

Signed-off-by: Robert Berger <rber.git@ReliableEmbeddedSystems.com>
---
 drivers/staging/zcache/tmem.c        |    2 +-
 drivers/staging/zcache/zcache-main.c |   10 ++++------
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/zcache/tmem.c b/drivers/staging/zcache/tmem.c
index 56c8e60..7d3f3d9 100644
--- a/drivers/staging/zcache/tmem.c
+++ b/drivers/staging/zcache/tmem.c
@@ -73,7 +73,7 @@ void tmem_register_pamops(struct tmem_pamops *m)
  */
 
 static struct tmem_obj
-*__tmem_obj_find(struct tmem_hashbucket*hb, struct tmem_oid *oidp,
+*__tmem_obj_find(struct tmem_hashbucket *hb, struct tmem_oid *oidp,
 		 struct rb_node **parent, struct rb_node ***link)
 {
 	struct rb_node *_parent = NULL, **rbnode;
diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index 52b43b7..0803ea3 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -2053,10 +2053,9 @@ static int __init zcache_init(void)
 		zbud_init();
 		register_shrinker(&zcache_shrinker);
 		old_ops = zcache_cleancache_register_ops();
-		pr_info("zcache: cleancache enabled using kernel "
-			"transcendent memory and compression buddies\n");
+		pr_info("zcache: cleancache enabled using kernel transcendent memory and compression buddies\n");
 		if (old_ops.init_fs != NULL)
-			pr_warning("zcache: cleancache_ops overridden");
+			pr_warn("zcache: cleancache_ops overridden");
 	}
 #endif
 #ifdef CONFIG_FRONTSWAP
@@ -2064,10 +2063,9 @@ static int __init zcache_init(void)
 		struct frontswap_ops old_ops;
 
 		old_ops = zcache_frontswap_register_ops();
-		pr_info("zcache: frontswap enabled using kernel "
-			"transcendent memory and zsmalloc\n");
+		pr_info("zcache: frontswap enabled using kernel transcendent memory and zsmalloc\n");
 		if (old_ops.init != NULL)
-			pr_warning("zcache: frontswap_ops overridden");
+			pr_warn("zcache: frontswap_ops overridden");
 	}
 #endif
 out:
-- 
1.7.9.5


       reply	other threads:[~2013-02-15 10:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <staging/zcache fixed some checkpatch issues>
2013-02-15 10:53 ` Robert Berger [this message]
2013-02-15 18:21   ` [PATCH] staging/zcache fixed some checkpatch issues Greg KH
2013-02-15 19:11     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360925580-18633-1-git-send-email-rber.git@ReliableEmbeddedSystems.com \
    --to=git.rber@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=rber.git@ReliableEmbeddedSystems.com \
    --cc=rber.git@gmail.com \
    --cc=sjenning@linux.vnet.ibm.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox