From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Mike Rapoport <mike@compulab.co.il>,
Laxman Dewangan <ldewangan@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] regulator: tps6586x: Having slew rate settings for other than SM0/1 is not fatal
Date: Sat, 16 Feb 2013 19:50:43 +0800 [thread overview]
Message-ID: <1361015443.11226.1.camel@phoenix> (raw)
Ignore the setting and show "Only SM0/SM1 can set slew rate" warning is enough,
then we can return 0 instead of -EINVAL in tps6586x_regulator_set_slew_rate().
Otherwise, probe() fails.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/tps6586x-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c
index e68382d..51da3f9 100644
--- a/drivers/regulator/tps6586x-regulator.c
+++ b/drivers/regulator/tps6586x-regulator.c
@@ -246,7 +246,7 @@ static int tps6586x_regulator_set_slew_rate(struct platform_device *pdev,
break;
default:
dev_warn(&pdev->dev, "Only SM0/SM1 can set slew rate\n");
- return -EINVAL;
+ return 0;
}
return tps6586x_write(parent, reg,
--
1.7.9.5
next reply other threads:[~2013-02-16 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 11:50 Axel Lin [this message]
2013-02-19 16:47 ` [PATCH] regulator: tps6586x: Having slew rate settings for other than SM0/1 is not fatal Stephen Warren
2013-02-19 18:26 ` Mark Brown
2013-02-19 19:32 ` Stephen Warren
2013-02-19 20:07 ` Mark Brown
2013-02-20 0:53 ` Axel Lin
2013-02-20 2:12 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361015443.11226.1.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox