* [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error
@ 2013-02-19 15:20 Axel Lin
2013-02-19 15:30 ` Lee Jones
2013-03-13 8:34 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-02-19 15:20 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Lee Jones, Jonas Aaberg, Bengt JONSSON, linux-kernel
This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.
drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
make: *** [vmlinux] Error 1
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 671f5b1..c346941 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -858,6 +858,7 @@ config EZX_PCAP
config AB8500_CORE
bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
+ select POWER_SUPPLY
select MFD_CORE
select IRQ_DOMAIN
help
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error
2013-02-19 15:20 [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error Axel Lin
@ 2013-02-19 15:30 ` Lee Jones
2013-03-13 8:34 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2013-02-19 15:30 UTC (permalink / raw)
To: Axel Lin; +Cc: Samuel Ortiz, Jonas Aaberg, Bengt JONSSON, linux-kernel
On Tue, 19 Feb 2013, Axel Lin wrote:
> This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.
>
> drivers/built-in.o: In function `ab8500_power_off':
> drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
> drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 671f5b1..c346941 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -858,6 +858,7 @@ config EZX_PCAP
> config AB8500_CORE
> bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
> depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
> + select POWER_SUPPLY
> select MFD_CORE
> select IRQ_DOMAIN
> help
I noticed and was going to fix this up myself - it's the right thing
to do.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error
2013-02-19 15:20 [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error Axel Lin
2013-02-19 15:30 ` Lee Jones
@ 2013-03-13 8:34 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2013-03-13 8:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Lee Jones, Jonas Aaberg, Bengt JONSSON, linux-kernel
Hi Axel,
On Tue, Feb 19, 2013 at 11:20:33PM +0800, Axel Lin wrote:
> This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.
>
> drivers/built-in.o: In function `ab8500_power_off':
> drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
> drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied to my mfd-fixes tree.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-13 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 15:20 [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error Axel Lin
2013-02-19 15:30 ` Lee Jones
2013-03-13 8:34 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox