From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934714Ab3BTJig (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Feb 2013 04:38:36 -0500
Received: from merlin.infradead.org ([205.233.59.134]:55199 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934575Ab3BTJic (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Feb 2013 04:38:32 -0500
Message-ID: <1361353109.10155.7.camel@laptop>
Subject: Re: [patch v5 07/15] sched: add new sg/sd_lb_stats fields for
 incoming fork/exec/wake balancing
From: Peter Zijlstra <peterz@infradead.org>
To: Alex Shi <alex.shi@intel.com>
Cc: torvalds@linux-foundation.org, mingo@redhat.com, tglx@linutronix.de,
        akpm@linux-foundation.org, arjan@linux.intel.com, bp@alien8.de,
        pjt@google.com, namhyung@kernel.org, efault@gmx.de,
        vincent.guittot@linaro.org, gregkh@linuxfoundation.org,
        preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org,
        linux-kernel@vger.kernel.org, morten.rasmussen@arm.com
Date: Wed, 20 Feb 2013 10:38:29 +0100
In-Reply-To: <1361164062-20111-8-git-send-email-alex.shi@intel.com>
References: <1361164062-20111-1-git-send-email-alex.shi@intel.com>
	 <1361164062-20111-8-git-send-email-alex.shi@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.6.2-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2013-02-18 at 13:07 +0800, Alex Shi wrote:
> @@ -4214,6 +4214,11 @@ struct sd_lb_stats {
>         unsigned int  busiest_group_weight;
>  
>         int group_imb; /* Is there imbalance in this sd */
> +
> +       /* Varibles of power awaring scheduling */
> +       unsigned int  sd_utils; /* sum utilizations of this domain */
> +       unsigned long sd_capacity;      /* capacity of this domain */
> +       struct sched_group *group_leader; /* Group which relieves
> group_min */
>  };
>  
>  /*
> @@ -4229,6 +4234,7 @@ struct sg_lb_stats {
>         unsigned long group_weight;
>         int group_imb; /* Is there an imbalance in the group ? */
>         int group_has_capacity; /* Is there extra capacity in the
> group? */
> +       unsigned int group_utils;       /* sum utilizations of group
> */
>  };

So I have two problems with the _utils name, firstly its a single value
and therefore we shouldn't give it a name in plural, secondly, whenever
I read utils I read utilities, not utilizations.

As a non native speaker I'm not entirely sure, but utilizations sounds
iffy to me, is there even a plural of utilization?