Re: [patch v5 02/15] sched: set initial load avg of new forked task

Alex Shi
2013-02-25T07:12:41Z

On 02/24/2013 06:57 PM, Preeti U Murthy wrote:
>> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> > index 26058d0..1452e14 100644
>> > --- a/kernel/sched/core.c
>> > +++ b/kernel/sched/core.c
>> > @@ -1559,6 +1559,7 @@ static void __sched_fork(struct task_struct *p)
>> > #if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED)
>> > p->se.avg.runnable_avg_period = 0;
>> > p->se.avg.runnable_avg_sum = 0;
>> > + p->se.avg.decay_count = 0;
>> > #endif
>> > #ifdef CONFIG_SCHEDSTATS
>> > memset(&p->se.statistics, 0, sizeof(p->se.statistics));
>> > @@ -1646,6 +1647,8 @@ void sched_fork(struct task_struct *p)
>> > p->sched_reset_on_fork = 0;
>> > }
>> >
> I think the following comment will help here.
> /* All forked tasks are assumed to have full utilization to begin with */

looks fine.

--
Thanks Alex