Re: [patch v5 06/15] sched: log the cpu utilization at rq

Preeti U Murthy
2013-02-20T12:11:14Z

Hi,

>> /*
>> * This is the main, per-CPU runqueue data structure.
>> *
>> @@ -481,6 +484,7 @@ struct rq {
>> #endif
>>
>> struct sched_avg avg;
>> + unsigned int util;
>> };
>>
>> static inline int cpu_of(struct rq *rq)
>
> You don't actually compute the rq utilization, you only compute the
> utilization as per the fair class, so if there's significant RT activity
> it'll think the cpu is under-utilized, whihc I think will result in the
> wrong thing.

Correct me if I am wrong,but isn't the current load balancer also
disregarding the real time tasks to calculate the domain/group/cpu level
load too?

What I mean is,if the answer to the above question is yes,then can we
safely assume that the furthur optimizations to the load balancer like
the power aware scheduler and the usage of per entity load tracking can
be done without considering the real time tasks?

Regards
Preeti U Murthy
>