From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Dong Aisheng" <dong.aisheng@linaro.org>,
linux-kernel@vger.kernel.org,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Mark Brown" <broonie@opensource.wolfsonmicro.com>
Subject: Re[14]: [PATCH v3] mfd: syscon: Add non-DT support
Date: Wed, 20 Feb 2013 21:27:45 +0400 [thread overview]
Message-ID: <1361381265.182415798@f53.mail.ru> (raw)
In-Reply-To: <201302201716.04650.arnd@arndb.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1936 bytes --]
> On Wednesday 20 February 2013, Alexander Shiyan wrote:
> > No. Target have a three SYSCON registers and two SYSFLG. All these registers
> > can be combined into three syscon devices.
> > Only these registers will be handled via syscon device, so it is not only one.
> > Or you mean about handle all register via syscon? It is not it.
>
> Yes, I was expecting that you would list all three pages in the resource
> for the syscon device, basically making all of the core clps711x
> registers available this way.
All other will be passed as resource to drivers, as for other drivers.
And this change replaces clps_read/write.
> > > treat the absence of DT information as an error, and a call to
> > > syscon_regmap_lookup_by_compatible or syscon_regmap_lookup_by_phandle
> > > will always return the syscon device that was registered first, or
> > > -EPROBE_DEFER for any error.
> >
> > The initial idea is search desired syscon device from drivers only by one function
> > (i.e. search syscon device by compatible string or by specific alias) and no depend
> > on DT or non-DT. I.e. define syscon device always at machine start (even if we run
> > machine from DTS), because device should be always present in system.
>
> I don't understand yet what the advantage for clps711x is over just a single
> register area that would get registered at boot time and replace all the
> clps_readl/clps_writel calls.
This cause a serious perfomance impact. Only SYSCON and SYSFLG is used
in several places and should be protected by spinlocks. Other registers
can be used without locks. And, as say before, clps_read/write will be replaced with
read/write when registers will passed as resource. First example of this change I
sent to you before (patchset for serial driver).
---
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2013-02-20 17:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 14:42 [PATCH v3] mfd: syscon: Add non-DT support Alexander Shiyan
2013-02-18 16:02 ` Arnd Bergmann
2013-02-19 5:52 ` Dong Aisheng
2013-02-19 7:03 ` Re[2]: " Alexander Shiyan
2013-02-19 7:55 ` Dong Aisheng
2013-02-19 8:02 ` Dong Aisheng
2013-02-19 8:56 ` Re[4]: " Alexander Shiyan
2013-02-19 9:58 ` Dong Aisheng
2013-02-19 10:54 ` Re[6]: " Alexander Shiyan
2013-02-20 5:20 ` Dong Aisheng
2013-02-20 5:41 ` Re[8]: " Alexander Shiyan
2013-02-20 6:01 ` Dong Aisheng
2013-02-20 10:06 ` Arnd Bergmann
2013-02-20 11:05 ` Dong Aisheng
2013-02-20 11:14 ` Arnd Bergmann
2013-02-20 11:28 ` Dong Aisheng
2013-02-20 12:16 ` Arnd Bergmann
2013-02-20 12:47 ` Re[10]: " Alexander Shiyan
2013-02-20 15:00 ` Arnd Bergmann
2013-02-20 16:06 ` Re[12]: " Alexander Shiyan
2013-02-20 17:16 ` Arnd Bergmann
2013-02-20 17:27 ` Alexander Shiyan [this message]
2013-02-20 21:27 ` Re[14]: " Arnd Bergmann
2013-02-21 15:27 ` Re[16]: " Alexander Shiyan
2013-02-19 10:49 ` Re[2]: " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361381265.182415798@f53.mail.ru \
--to=shc_work@mail.ru \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dong.aisheng@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox