From: Shawn Joo <sjoo@nvidia.com>
To: <broonie@opensource.wolfsonmicro.com>, <linux-kernel@vger.kernel.org>
Cc: <sjoo@nvidia.com>
Subject: [PATCH] regulator: core: use regulator name for sysfs
Date: Thu, 21 Feb 2013 16:53:57 +0900 [thread overview]
Message-ID: <1361433237-3217-1-git-send-email-sjoo@nvidia.com> (raw)
regulator is named by numbering on sysfs, e.g. regulator.0, regulator.1
it confuses to find desired regulator before counting the order.
add option for regulator name by use_name_onsysfs.
if it is true and name is not NULL, desc's name will be the name.
e.g. if name in desc is "LDO0", then regulator.LDO0 on sysfs.
otherwise it follows origin.
Signed-off-by: Shawn Joo <sjoo@nvidia.com>
---
drivers/regulator/core.c | 7 ++++++-
include/linux/regulator/driver.h | 1 +
2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 2785843..4dde54d 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3399,7 +3399,12 @@ regulator_register(const struct regulator_desc *regulator_desc,
rdev->dev.class = ®ulator_class;
rdev->dev.of_node = config->of_node;
rdev->dev.parent = dev;
- dev_set_name(&rdev->dev, "regulator.%d",
+ if (regulator_desc->use_name_onsysfs &&
+ regulator_desc->name != NULL)
+ dev_set_name(&rdev->dev, "regulator.%s",
+ regulator_desc->name);
+ else
+ dev_set_name(&rdev->dev, "regulator.%d",
atomic_inc_return(®ulator_no) - 1);
ret = device_register(&rdev->dev);
if (ret != 0) {
diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h
index d10bb0f..597f8dd 100644
--- a/include/linux/regulator/driver.h
+++ b/include/linux/regulator/driver.h
@@ -224,6 +224,7 @@ struct regulator_desc {
unsigned int bypass_mask;
unsigned int enable_time;
+ bool use_name_onsysfs;
};
/**
--
1.7.0.4
next reply other threads:[~2013-02-21 7:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 7:53 Shawn Joo [this message]
2013-02-21 19:24 ` [PATCH] regulator: core: use regulator name for sysfs Stephen Warren
2013-02-21 19:43 ` Mark Brown
2013-02-21 19:49 ` Stephen Warren
2013-02-21 19:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361433237-3217-1-git-send-email-sjoo@nvidia.com \
--to=sjoo@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox