From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Dong Aisheng" <b29396@freescale.com>
Cc: linux-kernel@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Dong Aisheng" <dong.aisheng@linaro.org>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Mark Brown" <broonie@opensource.wolfsonmicro.com>
Subject: Re[2]: [PATCH v4] mfd: syscon: Add non-DT support
Date: Fri, 22 Feb 2013 11:01:18 +0400 [thread overview]
Message-ID: <1361516478.223331042@f282.mail.ru> (raw)
In-Reply-To: <20130222065548.GA3252@b29396-Latitude-E6410>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 945 bytes --]
> On Thu, Feb 21, 2013 at 07:29:02PM +0400, Alexander Shiyan wrote:
> > This patch allow using syscon driver from the platform data, i.e.
> > possibility using driver on systems without oftree support.
> > For search syscon device from the client drivers,
> > "syscon_regmap_lookup_by_pdevname" function was added.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>
> [...]
>
> > + syscon->base = devm_ioremap_resource(dev, res);
> > + if (!syscon->base)
>
> Is this correct?
Hmm, of course IS_ERR should be used here...
v5?
>
> > + return -EBUSY;
> >
>
> Otherwise, i'm also ok with this patch.
> Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
>
> BTW, i did not see Samuel's tree having this new API.
> So, who will pick this patch?
I have same question.
---
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2013-02-22 7:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 15:29 [PATCH v4] mfd: syscon: Add non-DT support Alexander Shiyan
2013-02-21 16:18 ` [PATCH v4] mfd: syscon: Add non-DT suppor Arnd Bergmann
2013-02-22 6:55 ` [PATCH v4] mfd: syscon: Add non-DT support Dong Aisheng
2013-02-22 7:01 ` Alexander Shiyan [this message]
2013-02-22 7:13 ` Dong Aisheng
2013-02-22 7:27 ` Thierry Reding
2013-02-22 8:29 ` Dong Aisheng
2013-02-22 8:52 ` Thierry Reding
2013-02-22 9:20 ` Dong Aisheng
2013-02-22 9:24 ` Thierry Reding
2013-02-22 9:31 ` Dong Aisheng
2013-02-23 5:10 ` Re[2]: " Alexander Shiyan
2013-02-22 9:11 ` Arnd Bergmann
2013-02-22 9:19 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361516478.223331042@f282.mail.ru \
--to=shc_work@mail.ru \
--cc=arnd@arndb.de \
--cc=b29396@freescale.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dong.aisheng@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox