public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: joeyli <jlee@suse.com>
To: David Howells <dhowells@redhat.com>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org,
	Josh Boyer <jwboyer@redhat.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	"David S. Miller" <davem@davemloft.net>,
	Michal Marek <mmarek@suse.com>
Subject: Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509 already exists
Date: Fri, 22 Feb 2013 16:38:48 +0800	[thread overview]
Message-ID: <1361522328.8705.73.camel@linux-s257.site> (raw)
In-Reply-To: <804.1361456165@warthog.procyon.org.uk>

Hi David, 

Thanks for your review and point out!

於 四，2013-02-21 於 14:16 +0000，David Howells 提到：
> > +ifneq ($(shell pwd), $(srctree))
> 
> How reliable is this, I wonder?
> 
> David
> 

My current shell is bash, and I tried the '$(shell pwd)' in Makefile
works for grab the REAL path when the build path is a symbolic links to
kernel source directory. Looks the '$(shell pwd)' in Makefile was call
'/bin/pwd' but not 'the shell builtin pwd'.

But, in case the behavior is different between shells, I think used
'$(shell /bin/pwd)' will be better for make sure we call /bin/pwd from
coreutils.

I will send a second version of this patch, please consider for accept
if we need this change.


Thanks a lot!
Joey Lee


      reply	other threads:[~2013-02-22  8:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-21 11:23 [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509 already exists Chun-Yi Lee
2013-02-21 14:16 ` David Howells
2013-02-22  8:38   ` joeyli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361522328.8705.73.camel@linux-s257.site \
    --to=jlee@suse.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=herbert@gondor.hengli.com.au \
    --cc=jwboyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=rdunlap@xenotime.net \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox