Re: [PATCH] checkpatch: Improve CamelCase test for Page

Andrew Morton
2013-02-22T22:05:59Z

On Fri, 22 Feb 2013 17:01:48 -0500
Peter Hurley <peter@hurleysoftware.com> wrote:

> On Fri, 2013-02-22 at 12:59 -0800, Joe Perches wrote:
> > Add the ClearPage/SetPage/TestClearPage/TestSetPage
> > variants to the not reported Page CamelCase variables.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > scripts/checkpatch.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 747bcd7..8a32306 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2930,7 +2930,7 @@ sub process {
> > my $var = $1;
> > if ($var !~ /$Constant/ &&
> > $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
> > - $var !~ /^Page[A-Z]/ &&
> > + $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
> > !defined $camelcase{$var}) {
> > $camelcase{$var} = 1;
> > WARN("CAMELCASE",
> >
>
> In a recent patch, checkpatch gave this warning.
>
> WARNING: Avoid CamelCase: <tty->SAK_work>
> #35: FILE: drivers/tty/tty_io.c:1475:
> + flush_work(&tty->SAK_work);

If we start whitelisting these things, it will never end.

My (cruelly spurned) suggestion for this check is to grep the affected
files to see if the symbol is already present and if so, don't warn.

Or just revert the whole thing. I get tons of camelcase warnings, and
they're always unuseful/incorrect/ignored.