Re: [PATCH] checkpatch: Improve CamelCase test for Page

Andrew Morton
2013-02-22T23:08:49Z

On Fri, 22 Feb 2013 15:57:16 -0700
Shuah Khan <shuahkhan@gmail.com> wrote:

> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 747bcd7..e08e9f6 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2929,8 +2929,8 @@ sub process {
> > while ($line =~ m{($Constant|$Lval)}g) {
> > my $var = $1;
> > if ($var !~ /$Constant/ &&
> > - $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
> > - $var !~ /^Page[A-Z]/ &&
> > + $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
> > + $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && &&
> > !defined $camelcase{$var}) {
> > $camelcase{$var} = 1;
> > WARN("CAMELCASE",
> >
> >
>
> What are the guidelines on camelcase warnings on patches. A recent one
> I ran into is on a variable in a structure and fixing it would require
> changing the original variable.
>
> WARNING: Avoid CamelCase: <cp->Header.SGList>
> #67: FILE: drivers/scsi/hpsa.c:1409:
> + cp->Header.SGList = 0;
>
> WARNING: Avoid CamelCase: <cp->Header.SGTotal>
> #68: FILE: drivers/scsi/hpsa.c:1410:
> + cp->Header.SGTotal = 0;
>
> total: 0 errors, 2 warnings, 11 lines checked
>
> One would have to change a large portion of the code to fix it. In
> such cases, do we ignore this warning?

Yes, ignore the warning. In my experience this is always the case,
and it happens often.