Re: [PATCH] checkpatch: Improve CamelCase test for Page

Peter Hurley
2013-02-22T22:01:55Z

On Fri, 2013-02-22 at 12:59 -0800, Joe Perches wrote:
> Add the ClearPage/SetPage/TestClearPage/TestSetPage
> variants to the not reported Page CamelCase variables.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 747bcd7..8a32306 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2930,7 +2930,7 @@ sub process {
> my $var = $1;
> if ($var !~ /$Constant/ &&
> $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
> - $var !~ /^Page[A-Z]/ &&
> + $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
> !defined $camelcase{$var}) {
> $camelcase{$var} = 1;
> WARN("CAMELCASE",
>

In a recent patch, checkpatch gave this warning.

WARNING: Avoid CamelCase: <tty->SAK_work>
#35: FILE: drivers/tty/tty_io.c:1475:
+ flush_work(&tty->SAK_work);

'SAK' is the acronym for 'Secure Attention Key'. Identifiers which
relate to SAK handling have the above form; eg.,
do_SAK()
SAK_work
do_SAK_work
fn_SAK
vc_SAK
sysrq_handle_SAK

I didn't bother to mention it before, but since your addressing mm
CamelCase exceptions, perhaps

xxxx_XXXX
xx_XXX_xxx
XXX_xxx

could be exceptions as well?

Regards,
Peter Hurley