Re: [PATCH] sp5100_tco: Remove code that may cause a boot failure

[Paul Menzel <paulepanter@users.sourceforge.net>]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

Dear Takahisa,


Am Samstag, den 23.02.2013, 20:31 +0900 schrieb Takahisa Tanaka:
> The critical problem which can't boot OS until the power is completely
> cut off found on PC with SB700 chipset.

all SB700 boards or just a specific one?

> This patch fix the problem, but, this patch prevents the sp5100_tco
> driver from using watchdog timer function of chipset on PC with SP5100
> or SB7x0 chipset.
> 
> Re-programming the MMIO address registers for the watchdog timer must
> have generated the problem. However, I don't know root cause so far.
> So, I decided to remove the concerned codes.

Is that problem there since the first implementation or just with your
second patch? (I do not have the commit hashes and summaries ready.)

> Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1116835
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43176

The Bugzilla entry is not really related to this report. Please make
clear that this is the report the original patch wanted to fix. As
nobody closed it yet, it does not need to be reopened.

You can reference the LKML thread directly though.

https://lkml.org/lkml/2013/2/18/353

> Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
> ---
>  drivers/watchdog/sp5100_tco.c | 140 ++++--------------------------------------
>  drivers/watchdog/sp5100_tco.h |   2 +-
>  2 files changed, 14 insertions(+), 128 deletions(-)

[…]

To address Greg’s comment, your patch first has to land in Linus’ master
branch and only then it can be backported/applied to the stable series.
This will be done automatically if you just add

    CC: stable@vger.kernel.org

to the end of the commit message.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]