From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938532AbdAKQG7 (ORCPT ); Wed, 11 Jan 2017 11:06:59 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:46566 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbdAKQG4 (ORCPT ); Wed, 11 Jan 2017 11:06:56 -0500 X-AuditID: b6c32a58-f79946d000005960-6a-5876581d2523 From: Bartlomiej Zolnierkiewicz To: Julia Lawall Cc: linux-arm-kernel@lists.infradead.org, Tony Prisk , linux-fbdev@vger.kernel.org, Tomi Valkeinen , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/15] video: fbdev: use permission-specific DEVICE_ATTR variants Date: Wed, 11 Jan 2017 17:06:49 +0100 Message-id: <13619076.BMdhC73baQ@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1477769829-22230-5-git-send-email-Julia.Lawall@lip6.fr> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsWy7bCmlq5sRFmEwb1j/BbLHpxmtNh6S9pi 0+NrrBYn+j6wWlzeNYfNouXyCmaL9fNvsTmwe+zdkuWxeUm9x/n/Lewex29sZ/L4vEkugDWK yyYlNSezLLVI3y6BK2PR+9MsBd94Ki7Om8TUwHiYq4uRk0NCwETiTtszVghbTOLCvfVsILaQ wFJGiQcv9LsYuYDsdiaJb6vPsME0nH/Zzw6RmMMo0dG/ngXC+coo8Xj/YXaQKjYBK4mJ7asY QWwRAXWJ1g27wGxmgWuMEo0vU0FsYYFwicdQq1kEVCXWb5wIZvMKaEl8XXWfCcQWFfCS2LKv HczmFHCVeLVwKRNEjaDEj8n3WCBmykvs2z+VFcLWkTh7bB0jyEESAovYJR70HQI6mwPIkZXY dIAZ4gMXiYvzd7JD2MISr45vgbKlJf4uvcUIYU9nlNj+WwJizmZGiVW7J0AVWUscPn4Rahmf RO/vJ0wQ83klOtqEIEo8JG72b2KCsB0lJl2+CQ2ty4wSTXs+Mk9glJ+F5IdZSH6YheSHBYzM qxjFUguKc9NTi00LTPSKE3OLS/PS9ZLzczcxgtOJVsQOxn8zgg4xCnAwKvHwCtiXRQixJpYV V+YeYpTgYFYS4Q0LAgrxpiRWVqUW5ccXleakFh9ilOZgURLnXVBhHSEkkJ5YkpqdmlqQWgST ZeLglGpgVLf4u/PYqTuOf09PdZ/QXxeoyvzD2Upiw+c1swRWtKplXLR9tXHtbd8pT7zZvl19 Kfjk+qo2/+/qN5039ZTty+o+IewYdr6Vt/HItE0JfmtaPn9c9+6X/aJNjIcb5U44Cp7z2Svi u074kTL/wpZ0L7bujj1iTL+e3jVbUMRw8+eDmY9dFDmOXlNiKc5INNRiLipOBABOwL/mIwMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsVy+t9jQV2ZiLIIg80b9SyWPTjNaLH1lrTF psfXWC1O9H1gtbi8aw6bRcvlFcwW6+ffYnNg99i7Jctj85J6j/P/W9g9jt/YzuTxeZNcAGuU m01GamJKapFCal5yfkpmXrqtUmiIm66FkkJeYm6qrVKErm9IkJJCWWJOKZBnZIAGHJwD3IOV 9O0S3DIWvT/NUvCNp+LivElMDYyHuboYOTkkBEwkzr/sZ4ewxSQu3FvP1sXIxSEkMItR4u/0 LcwQzldGiT/np7CCVLEJWElMbF/FCGKLCKhLtG7YxQhSxCxwhVFi3dU3YEXCAuESj9uegdks AqoS6zdOBLN5BbQkvq66zwRiiwp4SWzZ1w5mcwq4SrxauBTMFhKol3h68TEzRL2gxI/J91hA bGYBeYl9+6eyQthaEut3HmeawAh0J0LZLCRls5CULWBkXsUokVqQXFCclJ5rlJdarlecmFtc mpeul5yfu4kRHGHPpHcwHt7lfohRgINRiYdXwL4sQog1say4MvcQowQHs5II74IwoBBvSmJl VWpRfnxRaU5q8SFGU6AHJzJLiSbnA6M/ryTe0MTcxNzYwMLc0tLESEmct3H2s3AhgfTEktTs 1NSC1CKYPiYOTqkGRl/PY2nH93W5GV22vi+hEvt/+v3bcs8n8+7mCLKcZfs18kSA0ZrSJQ7X Kioe+j23fdRbxyNy4JKGyNX7DA7b1/YyfsjZE+viEDSjsnyLidfNzyV87kyNCTfuGSofslfV iZPuePNQfvLTXXLPXerCL1XccutecGpfjbPV8dnGajLXzF5Wx3oZKLEUZyQaajEXFScCAK6v /T/GAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111160652epcas5p3f1a8c0858a669910b51ece8cfe654a96 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170111160652epcas5p3f1a8c0858a669910b51ece8cfe654a96 X-RootMTR: 20170111160652epcas5p3f1a8c0858a669910b51ece8cfe654a96 References: <1477769829-22230-1-git-send-email-Julia.Lawall@lip6.fr> <1477769829-22230-5-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Saturday, October 29, 2016 09:36:58 PM Julia Lawall wrote: > Use DEVICE_ATTR_RW for read-write attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @rw@ > declarer name DEVICE_ATTR; > identifier x,x_show,x_store; > @@ > > DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store); > > @script:ocaml@ > x << rw.x; > x_show << rw.x_show; > x_store << rw.x_store; > @@ > > if not (x^"_show" = x_show && x^"_store" = x_store) > then Coccilib.include_match false > > @@ > declarer name DEVICE_ATTR_RW; > identifier rw.x,rw.x_show,rw.x_store; > @@ > > - DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store); > + DEVICE_ATTR_RW(x); > // > > Signed-off-by: Julia Lawall Thanks, patch queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/wm8505fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/wm8505fb.c b/drivers/video/fbdev/wm8505fb.c > index e925619..253ffe9 100644 > --- a/drivers/video/fbdev/wm8505fb.c > +++ b/drivers/video/fbdev/wm8505fb.c > @@ -182,7 +182,7 @@ static ssize_t contrast_store(struct device *dev, > return count; > } > > -static DEVICE_ATTR(contrast, 0644, contrast_show, contrast_store); > +static DEVICE_ATTR_RW(contrast); > > static inline u_int chan_to_field(u_int chan, struct fb_bitfield *bf) > {