Re: [PATCH 1/5] staging: android: lowmemorykiller: Add config option to support oom_adj values

Arve Hjønnevåg
2013-02-27T22:38:09Z

On Wed, Feb 27, 2013 at 2:18 PM, David Rientjes <rientjes@google.com> wrote:
> On Tue, 26 Feb 2013, John Stultz wrote:
>
>> From: Arve Hjønnevåg <arve@android.com>
>>
>> The conversion to use oom_score_adj instead of the deprecated oom_adj
>> values breaks existing user-space code. Add a config option to convert
>> oom_adj values written to oom_score_adj values if they appear to be
>> valid oom_adj values.
>>
>
> Umm, writes to /proc/pid/oom_adj already are converted to the
> /proc/pid/oom_score_adj scale linearly. Heavy NACK to this patch since
> oom_adj is completely deprecated.

I know it is deprecated, but your change, staging: android,
lowmemorykiller: convert to use oom_score_adj, broke existing
user-space code that still write to /proc/pid/oom_adj. This option
lets you build a kernel that supports our user-space code until that
user-space has been converted to use /proc/pid/oom_score_adj.

--
Arve Hjønnevåg