Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

Linus Walleij
2013-03-07T03:23:57Z

Hi Mika,

On Wed, Feb 27, 2013 at 4:25 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:

> -static int ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr)
> +static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr)
> {
> - return (ichx_priv.use_gpio & (1 << (nr / 32))) ? 0 : -ENXIO;
> + return ichx_priv.use_gpio & (1 << (nr / 32));
> }

Strictly speaking what you're returning there is not a bool.
Shouldn't it be:

return !!(ichx_priv.use_gpio & (1 << (nr / 32)));

?

Yours,
Linus Walleij