From: Joern Engel <joern@logfs.org>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, Jeff Moyer <jmoyer@redhat.com>,
Joern Engel <joern@logfs.org>
Subject: [PATCH 3/9] printk: add CON_ALLDATA console flag
Date: Thu, 28 Feb 2013 16:39:56 -0500 [thread overview]
Message-ID: <1362087602-8979-4-git-send-email-joern@logfs.org> (raw)
In-Reply-To: <1362087602-8979-1-git-send-email-joern@logfs.org>
For consoles like netconsole and blockconsole the loglevel filtering
really doesn't make any sense. If a line gets printed at all, please
send it down to that console, no questions asked.
For vga_con, it is a completely different matter, as the user sitting in
front of his console could get spammed by messages while trying to login
or similar. So ignore_loglevel doesn't work as a one-size-fits-all
approach. Add a per-console flag instead so that netconsole and
blockconsole can opt-in.
Signed-off-by: Joern Engel <joern@logfs.org>
---
include/linux/console.h | 1 +
kernel/printk.c | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/console.h b/include/linux/console.h
index dedb082..eed92ad 100644
--- a/include/linux/console.h
+++ b/include/linux/console.h
@@ -116,6 +116,7 @@ static inline int con_debug_leave(void)
#define CON_BOOT (8)
#define CON_ANYTIME (16) /* Safe to call when cpu is offline */
#define CON_BRL (32) /* Used for a braille device */
+#define CON_ALLDATA (64) /* per-console ignore_loglevel */
struct console {
char name[16];
diff --git a/kernel/printk.c b/kernel/printk.c
index 267ce78..5221c59 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -1261,8 +1261,6 @@ static void call_console_drivers(int level, const char *text, size_t len)
trace_console(text, 0, len, len);
- if (level >= console_loglevel && !ignore_loglevel)
- return;
if (!console_drivers)
return;
@@ -1276,6 +1274,9 @@ static void call_console_drivers(int level, const char *text, size_t len)
if (!cpu_online(smp_processor_id()) &&
!(con->flags & CON_ANYTIME))
continue;
+ if (level >= console_loglevel && !ignore_loglevel &&
+ !(con->flags & CON_ALLDATA))
+ continue;
con->write(con, text, len);
}
}
--
1.7.10.4
next prev parent reply other threads:[~2013-02-28 23:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 21:39 [PATCH 0/9] Add blockconsole version 1.1 (try 2) Joern Engel
2013-02-28 21:39 ` [PATCH 1/9] do_mounts: constify name_to_dev_t parameter Joern Engel
2013-02-28 21:39 ` [PATCH 2/9] add blockconsole version 1.1 Joern Engel
2013-02-28 21:39 ` Joern Engel [this message]
2013-03-01 14:52 ` [PATCH 3/9] printk: add CON_ALLDATA console flag Jeff Moyer
2013-03-01 14:58 ` Borislav Petkov
2013-03-01 15:08 ` Jeff Moyer
2013-03-01 15:31 ` Borislav Petkov
2013-03-01 15:42 ` Jeff Moyer
2013-03-01 15:58 ` Borislav Petkov
2013-03-01 16:15 ` Jörn Engel
2013-02-28 21:39 ` [PATCH 4/9] netconsole: use CON_ALLDATA Joern Engel
2013-02-28 21:39 ` [PATCH 5/9] blockconsole: " Joern Engel
2013-03-01 16:11 ` Jeff Moyer
2013-03-01 16:20 ` Jörn Engel
2013-03-01 17:52 ` Borislav Petkov
2013-03-01 16:31 ` Jörn Engel
2013-03-01 17:56 ` Borislav Petkov
2013-02-28 21:39 ` [PATCH 6/9] bcon: add a release work struct Joern Engel
2013-02-28 21:40 ` [PATCH 7/9] bcon: check for hdparm in bcon_tail Joern Engel
2013-02-28 21:40 ` [PATCH 8/9] blockconsole: Allow to pass a device file path to bcon_tail Joern Engel
2013-02-28 21:40 ` [PATCH 9/9] bcon: remove version 1.0 support Joern Engel
2013-03-01 17:15 ` [PATCH 0/9] Add blockconsole version 1.1 (try 2) Takashi Iwai
2013-03-01 16:22 ` Jörn Engel
2013-03-05 17:36 ` Takashi Iwai
2013-03-06 19:49 ` Jörn Engel
2013-03-07 18:46 ` Takashi Iwai
2013-03-07 18:51 ` [PATCH 0/3] blockconsole: make it a module Takashi Iwai
2013-03-07 18:51 ` [PATCH 1/3] Export sched_setscheduler_nocheck() Takashi Iwai
2013-03-07 18:51 ` [PATCH 2/3] block/partitions: Support dynamic addition of partition checkers Takashi Iwai
2013-03-07 18:51 ` [PATCH 3/3] blockconsole: Allow to be a module Takashi Iwai
2013-03-01 17:17 ` [PATCH 1/3] blockconsole: Fix undefined MAX_RT_PRIO Takashi Iwai
2013-03-01 17:17 ` [PATCH 2/3] blockconsole: Rename device_lock with bc_device_lock Takashi Iwai
2013-03-01 17:17 ` [PATCH 3/3] blockconsole: Mark a local work struct static Takashi Iwai
2013-03-20 22:52 ` [PATCH 0/9] Add blockconsole version 1.1 (try 2) Borislav Petkov
2013-03-21 6:30 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362087602-8979-4-git-send-email-joern@logfs.org \
--to=joern@logfs.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox