From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 2/2] regmap: cache: Store caches in native register format where possible
Date: Mon, 4 Mar 2013 09:14:40 +0800 [thread overview]
Message-ID: <1362359680-23747-2-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1362359680-23747-1-git-send-email-broonie@opensource.wolfsonmicro.com>
This allows the cached data to be sent directly to the device when
we sync it.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/base/regmap/regcache.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 6948996..0f4fb8b 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -45,8 +45,8 @@ static int regcache_hw_init(struct regmap *map)
tmp_buf = kmalloc(map->cache_size_raw, GFP_KERNEL);
if (!tmp_buf)
return -EINVAL;
- ret = regmap_bulk_read(map, 0, tmp_buf,
- map->num_reg_defaults_raw);
+ ret = regmap_raw_read(map, 0, tmp_buf,
+ map->num_reg_defaults_raw);
map->cache_bypass = cache_bypass;
if (ret < 0) {
kfree(tmp_buf);
@@ -421,6 +421,13 @@ bool regcache_set_val(struct regmap *map, void *base, unsigned int idx,
if (regcache_get_val(map, base, idx) == val)
return true;
+ /* Use device native format if possible */
+ if (map->format.format_val) {
+ map->format.format_val(base + (map->cache_word_size * idx),
+ val, 0);
+ return false;
+ }
+
switch (map->cache_word_size) {
case 1: {
u8 *cache = base;
@@ -449,6 +456,11 @@ unsigned int regcache_get_val(struct regmap *map, const void *base,
if (!base)
return -EINVAL;
+ /* Use device native format if possible */
+ if (map->format.parse_val)
+ return map->format.parse_val(base +
+ (map->cache_word_size * idx));
+
switch (map->cache_word_size) {
case 1: {
const u8 *cache = base;
--
1.7.10.4
next prev parent reply other threads:[~2013-03-04 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 1:14 [PATCH 1/2] regmap: core: Split out in place value parsing Mark Brown
2013-03-04 1:14 ` Mark Brown [this message]
2013-03-18 23:41 ` Stephen Warren
[not found] ` <20130319165007.GA22168@opensource.wolfsonmicro.com>
2013-03-20 22:19 ` Stephen Warren
2013-03-20 22:33 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362359680-23747-2-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox