[PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

Sachin Kamat
2013-03-04T09:20:08Z

Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/gpio/gpio-vt8500.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-vt8500.c b/drivers/gpio/gpio-vt8500.c
index 81683ca..b2d8d6f 100644
--- a/drivers/gpio/gpio-vt8500.c
+++ b/drivers/gpio/gpio-vt8500.c
@@ -309,11 +309,9 @@ static int vt8500_gpio_probe(struct platform_device *pdev)
return -ENODEV;
}

- gpio_base = devm_request_and_ioremap(&pdev->dev, res);
- if (!gpio_base) {
- dev_err(&pdev->dev, "Unable to map GPIO registers\n");
- return -ENOMEM;
- }
+ gpio_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(gpio_base))
+ return PTR_ERR(gpio_base);

ret = vt8500_add_chips(pdev, gpio_base, of_id->data);

--
1.7.4.1