From: Michel Lespinasse <walken@google.com>
To: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
paulmck@linux.vnet.ibm.com, Rusty Russell <rusty@rustcorp.com.au>,
rostedt@goodmis.org, tglx@linutronix.de,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 0/2] tighten lglock lockdep annotations
Date: Mon, 4 Mar 2013 18:17:23 -0800 [thread overview]
Message-ID: <1362449845-7492-1-git-send-email-walken@google.com> (raw)
Oleg Nesterov recently noticed that the lockdep annotations in lglock.c
are not sufficient to detect some obvious deadlocks, such as
lg_local_lock(LOCK) + lg_local_lock(LOCK) or
spin_lock(X) + lg_local_lock(Y) vs lg_local_lock(Y) + spin_lock(X).
Both issues can be fixed by indicating to lockdep that lglock's local
locks are not recursive.
Patch 1 introduces helper macros for lockdep annotations.
Patch 2 makes sure to use the appropriate helper macros to indicate that
the lglock local lock is a shared, non-recursive lock.
Michel Lespinasse (2):
lockdep: introduce lock_acquire_exclusive/shared helper macros
lglock: update lockdep annotations to report recursive local locks
include/linux/lockdep.h | 92 +++++++++++++------------------------------------
kernel/lglock.c | 12 +++----
2 files changed, 29 insertions(+), 75 deletions(-)
--
1.8.1.3
next reply other threads:[~2013-03-05 2:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 2:17 Michel Lespinasse [this message]
2013-03-05 2:17 ` [PATCH 1/2] lockdep: introduce lock_acquire_exclusive/shared helper macros Michel Lespinasse
2013-03-05 15:19 ` Lai Jiangshan
2013-03-05 15:40 ` Michel Lespinasse
2013-03-05 17:06 ` Oleg Nesterov
2013-03-05 2:17 ` [PATCH 2/2] lglock: update lockdep annotations to report recursive local locks Michel Lespinasse
2013-03-05 17:42 ` Oleg Nesterov
2013-03-05 18:24 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362449845-7492-1-git-send-email-walken@google.com \
--to=walken@google.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox