Re: [PATCH 1/1] drivers/misc: Add Altera System ID driver

Arnd Bergmann
2013-03-04T03:32:36Z

On Monday 04 March 2013, Ley Foon Tan wrote:
> This patch is to add Altera System ID driver.
> User can obtain the system ID and timestamp of the system by
> reading the sysfs entry.
>
> Usage:
> cat /sys/bus/platform/devices/[addr].sysid/sysid/id
> cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp
>
> Signed-off-by: Ley Foon Tan <lftan@altera.com>

All sysfs files need documentation in Documentation/ABI/.

This driver looks like it should instead be using the infrastructure we
have for identifying an SoC in drivers/base/soc.c, which is currently
only used by the ARM u8500 platform but was introduced as a generic
interface for this a while ago.

Arnd